| 1 |
On 12/21/2015 07:04 AM, Alexander Berntsen wrote: |
| 2 |
> The patch looks OK. |
| 3 |
> |
| 4 |
> On 20/12/15 23:32, Zac Medico wrote: |
| 5 |
>> Since the Manifest "stable mtime" behavior could be have |
| 6 |
>> undiscovered bugs, disable it by default, and add a corresponding |
| 7 |
>> egencache option. |
| 8 |
> You have an English børk here -- "could be have". |
| 9 |
|
| 10 |
Thanks, fixed. |
| 11 |
|
| 12 |
>> [PATCH v2] fixes preserved_stats to contain stat results for |
| 13 |
>> self.pkgdir even if the Manifest has been removed, and also |
| 14 |
>> explains the reasoning for disabling the stable mtime behavior by |
| 15 |
>> default. |
| 16 |
> Maybe this could go into the commit message? I'd not mind a more |
| 17 |
> verbose message for this. |
| 18 |
|
| 19 |
In v3 I've added a comment block to Manifest.write in order to document |
| 20 |
subtle issues involving the mtime of self.pkgdir that must be accounted for. |
| 21 |
-- |
| 22 |
Thanks, |
| 23 |
Zac |
Archives