Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] doman: QA-complain on compressed files
Date: Sun, 09 Jul 2017 21:35:36
Message-Id: 1499636130.21734.1.camel@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] doman: QA-complain on compressed files by Brian Dolbec
1 On nie, 2017-07-02 at 11:57 -0700, Brian Dolbec wrote:
2 > On Sun, 2 Jul 2017 19:57:57 +0200
3 > Michał Górny <mgorny@g.o> wrote:
4 >
5 > > Passing compressed files to doman is not permitted by the PMS.
6 > > However, Portage permitting it results in many developers repeatedly
7 > > violating this and arguing that it's permitted because nobody
8 > > explicitly forbids it. Add an explicit QA warning to Portage to cease
9 > > it. ---
10 > > bin/ebuild-helpers/doman | 1 +
11 > > 1 file changed, 1 insertion(+)
12 > >
13 > > diff --git a/bin/ebuild-helpers/doman b/bin/ebuild-helpers/doman
14 > > index da66ac335..43d29f22e 100755
15 > > --- a/bin/ebuild-helpers/doman
16 > > +++ b/bin/ebuild-helpers/doman
17 > > @@ -30,6 +30,7 @@ for x in "$@" ; do
18 > >
19 > > # These will be automatically decompressed by ecompressdir.
20 > > if has ${suffix} Z gz bz2 ; then
21 > > + eqawarn "QA Notice: doman argument '${x}' is
22 > > compressed, this is not portable" realname=${x%.*}
23 > > suffix=${realname##*.}
24 > > fi
25 >
26 > sounds good
27 >
28
29 Merged.
30
31 --
32 Best regards,
33 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature