Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] doman: QA-complain on compressed files
Date: Sun, 02 Jul 2017 18:57:17
Message-Id: 20170702115714.722e83b9.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] doman: QA-complain on compressed files by "Michał Górny"
1 On Sun, 2 Jul 2017 19:57:57 +0200
2 Michał Górny <mgorny@g.o> wrote:
3
4 > Passing compressed files to doman is not permitted by the PMS.
5 > However, Portage permitting it results in many developers repeatedly
6 > violating this and arguing that it's permitted because nobody
7 > explicitly forbids it. Add an explicit QA warning to Portage to cease
8 > it. ---
9 > bin/ebuild-helpers/doman | 1 +
10 > 1 file changed, 1 insertion(+)
11 >
12 > diff --git a/bin/ebuild-helpers/doman b/bin/ebuild-helpers/doman
13 > index da66ac335..43d29f22e 100755
14 > --- a/bin/ebuild-helpers/doman
15 > +++ b/bin/ebuild-helpers/doman
16 > @@ -30,6 +30,7 @@ for x in "$@" ; do
17 >
18 > # These will be automatically decompressed by ecompressdir.
19 > if has ${suffix} Z gz bz2 ; then
20 > + eqawarn "QA Notice: doman argument '${x}' is
21 > compressed, this is not portable" realname=${x%.*}
22 > suffix=${realname##*.}
23 > fi
24
25 sounds good
26
27 --
28 Brian Dolbec <dolsen>

Replies