| 1 |
On 03/14/2016 10:14 AM, Zac Medico wrote: |
| 2 |
> On 03/05/2016 01:37 PM, Brian Dolbec wrote: |
| 3 |
> |
| 4 |
>> Zac, I'm done with code changes in the rewrite. Ready for a last look |
| 5 |
>> before a merge. Can you have a look again? I did some changes/fixes |
| 6 |
>> and rebased them in. Floppym hasn't reported any more bugs, so I think |
| 7 |
>> it's ready for broader testing in a release. Then we can work on |
| 8 |
>> moving all the test data to a separate file in the tree or downloaded... |
| 9 |
> |
| 10 |
> The dynamic_data stuff in Scanner is a little hard to follow. Then it |
| 11 |
> calls dynamic_data.update(rdata), is there any chance that the update |
| 12 |
> operation might clobber something that shouldn't have been clobbered? |
| 13 |
|
| 14 |
To clarify my question, suppose that one function returns {'foo': True} |
| 15 |
and another one returns {'foo', False}, so now there first {'foo': True} |
| 16 |
setting is forgotten. Is that going to be a problem? |
| 17 |
-- |
| 18 |
Thanks, |
| 19 |
Zac |
Archives