Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: Zac Medico <zmedico@g.o>
Cc: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] fetch(): fix support for digest size=None
Date: Sun, 05 Apr 2015 21:56:10
Message-Id: 20150405235554.286010f5@pomiot.lan
In Reply to: Re: [gentoo-portage-dev] [PATCH] fetch(): fix support for digest size=None by Zac Medico
1 Dnia 2015-04-05, o godz. 10:57:57
2 Zac Medico <zmedico@g.o> napisał(a):
3
4 > On 04/05/2015 12:59 AM, Michał Górny wrote:
5 > > It seems that the code initially supported fetching without size
6 > > 'digest' but it got broken over time. Add proper conditionals to avoid
7 > > ugly failures in this case.
8 >
9 > If we're handling this case, then we should probably not assume that the
10 > dict contains a "size" key. So, we could check that dict.get("size") is
11 > not None.
12
13 I agree. Could you take it from this point? I don't really have time to
14 do this, so I limit myself to solving the bugs I need to get moving :/.
15
16 --
17 Best regards,
18 Michał Górny