| 1 |
On 2/20/20 10:51 AM, Ulrich Mueller wrote: |
| 2 |
>>>>>> On Thu, 20 Feb 2020, Zac Medico wrote: |
| 3 |
> |
| 4 |
>> Looks good. Even though earlier EAPIs are deprecated, would there be a |
| 5 |
>> problem with updating __eapi4_src_install for consistency? |
| 6 |
> |
| 7 |
> I'd rather not, because for EAPIs 4 and 5 PMS specifies that the return |
| 8 |
> status of declare -p should be tested [1]. |
| 9 |
> |
| 10 |
> Presumably it wouldn't make much of a difference, because we don't |
| 11 |
> account for the "assigned, but empty" case in these EAPIs. |
| 12 |
> src_install format 4 will just fail for DOCS="" or DOCS=(). |
| 13 |
> |
| 14 |
> [1] https://projects.gentoo.org/pms/7/pms.html#x1-94001r7 |
| 15 |
> |
| 16 |
|
| 17 |
Ok, that sounds reasonable. Thanks for the explanation. |
| 18 |
|
| 19 |
Please go ahead and merge. |
| 20 |
-- |
| 21 |
Thanks, |
| 22 |
Zac |
Archives