Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | Zac Medico <zmedico@g.o> | ||
| Cc: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH] einstalldocs: Fix test for DOCS being unset. | ||
| Date: | Thu, 20 Feb 2020 18:51:37 | ||
| Message-Id: | uimk1jdn7@kph.uni-mainz.de | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH] einstalldocs: Fix test for DOCS being unset. by Zac Medico |
||
| 1 | >>>>> On Thu, 20 Feb 2020, Zac Medico wrote: |
| 2 | |
| 3 | > Looks good. Even though earlier EAPIs are deprecated, would there be a |
| 4 | > problem with updating __eapi4_src_install for consistency? |
| 5 | |
| 6 | I'd rather not, because for EAPIs 4 and 5 PMS specifies that the return |
| 7 | status of declare -p should be tested [1]. |
| 8 | |
| 9 | Presumably it wouldn't make much of a difference, because we don't |
| 10 | account for the "assigned, but empty" case in these EAPIs. |
| 11 | src_install format 4 will just fail for DOCS="" or DOCS=(). |
| 12 | |
| 13 | [1] https://projects.gentoo.org/pms/7/pms.html#x1-94001r7 |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [PATCH] einstalldocs: Fix test for DOCS being unset. | Zac Medico <zmedico@g.o> |