[gentoo-portage-dev] [PATCH] repoman: check for ebuilds not using slot operator against multi-slot packages.

[Michał Górny]

The idea if that a particular dependency atom matches more than one slot
of a package, you are supposed to either use := or :* operator
(or a specific :slot dependency), whichever is appropriate.

This will help catching mistakes (when packages become slotted) and make
cross-slot behavior clear (it is undefined with no slot operator). I
will estimate the amount of new warnings later.
---
 bin/repoman | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

diff --git a/bin/repoman b/bin/repoman
index 71fc7f0..b169393 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -78,7 +78,8 @@ from portage.output import ConsoleStyleFile, StyleWriter
 from portage.util import writemsg_level
 from portage.util._argparse import ArgumentParser
 from portage.package.ebuild.digestgen import digestgen
-from portage.eapi import eapi_has_iuse_defaults, eapi_has_required_use
+from portage.eapi import eapi_has_iuse_defaults, eapi_has_required_use, \
+	eapi_has_slot_operator
 
 if sys.hexversion >= 0x3000000:
 	basestring = str
@@ -351,6 +352,7 @@ qahelp = {
 	"LICENSE.deprecated": "This ebuild is listing a deprecated license.",
 	"KEYWORDS.invalid": "This ebuild contains KEYWORDS that are not listed in profiles/arch.list or for which no valid profile was found",
 	"RDEPEND.implicit": "RDEPEND is unset in the ebuild which triggers implicit RDEPEND=$DEPEND assignment (prior to EAPI 4)",
+	"RDEPEND.slotop": "RDEPEND matches more than one SLOT but does not use := or :* slot operator",
 	"RDEPEND.suspect": "RDEPEND contains a package that usually only belongs in DEPEND.",
 	"RESTRICT.invalid": "This ebuild contains invalid RESTRICT values.",
 	"digest.assumed": "Existing digest must be assumed correct (Package level only)",
@@ -399,6 +401,7 @@ qawarnings = set((
 "KEYWORDS.missing",
 "PDEPEND.suspect",
 "RDEPEND.implicit",
+"RDEPEND.slotop",
 "RDEPEND.suspect",
 "virtual.suspect",
 "RESTRICT.invalid",
@@ -2047,10 +2050,25 @@ for x in effective_scanlist:
 					# Skip dependency.unknown for blockers, so that we
 					# don't encourage people to remove necessary blockers,
 					# as discussed in bug #382407.
-					if not is_blocker and \
-						not portdb.xmatch("match-all", atom) and \
-						not atom.cp.startswith("virtual/"):
-						unknown_pkgs.add((mytype, atom.unevaluated_atom))
+					# Also skip it for slot operator checks.
+					if not is_blocker:
+						atom_matches = portdb.xmatch("match-all", atom)
+						if not atom_matches and not atom.cp.startswith("virtual/"):
+							unknown_pkgs.add((mytype, atom.unevaluated_atom))
+
+						# If no slot or slot operator is specified in RDEP...
+						if (not atom.slot and not atom.slot_operator
+								and mytype == 'RDEPEND' and eapi_has_slot_operator(eapi)):
+							# Check whether it doesn't match more than one.
+							dep_slots = frozenset(
+									[portdb.aux_get(cpv, ['SLOT'])[0].split('/')[0]
+										for cpv in atom_matches])
+							if len(dep_slots) > 1:
+								stats[mytype + ".slotop"] += 1
+								fails[mytype + ".slotop"].append(
+									relative_path +
+									": %s: '%s' matches more than one slot, please use := or :* slot operator" %
+									(mytype, atom))
 
 					if catdir != "virtual":
 						if not is_blocker and \
-- 
2.0.4