Re: [gentoo-portage-dev] Commit Policy

[Tom Wijsman]

On Mon, 13 Jan 2014 07:43:27 +0100
Sebastian Luther <SebastianLuther@×××.de> wrote:

> Am 10.01.2014 11:35, schrieb Brian Dolbec:
> > First off.  Welcome and than you for responding to help with
> > portage.
> >
> > With this many people, we should be able to make good progress
> > without overloading any one person.
> >
> > General rule is to submit all patches to this list for review and
> > approval before committing.
> >
> > Remember to do these always: 1) run pyflakes on your changes to
> > check for faults, misssing imports, variables undefined,...
> >
> > 2) run the testsuite to check for breakage.  It is in the base
> > directory called runtests.sh.  Please try to test it with all
> > minimum supported python versions, but if you have pypy, and some
> > others, then great.
> >
> > 3) any new code that could break things, make a test for it if at
> > all possible.
> >
> >
> > The general exception for patch submittal is for trivial changes
> > such as typo fixes, etc..
> >
> > It will take a bit of time for everyone to acclimate themselves
> > into our new team.  So, I was thinking we give it 2 months, then
> > hold an election for lead in March.  Is that alright with
> > everyone?
> >
> > Thanks
> >
>
> One more useful thing:
>
> Put this in ~/.gitconfig:
> [color]
> 	ui = auto
>
> This way git diff will use colors, including highlighting of trailing
> whitespace.

Instead of this, we can add vapier's suggestion to set a proper name
and e-mail; we can add other minor issues like these to the policy in
the future as they become more visible (or Git functionality changes).

-- 
With kind regards,

Tom Wijsman (TomWij)
Gentoo Developer

E-mail address  : TomWij@g.o
GPG Public Key  : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2  ABF0 95B2 1FCD 6D34 E57D