Archives
Archives
| From: | Zac Medico <zmedico@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Cc: | "Michał Górny" <mgorny@g.o> | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH v2] Respect nonfatal in unpack(), econf() and einstall() | ||
| Date: | Sun, 30 Nov 2014 19:26:23 | ||
| Message-Id: | 547B6F58.1060500@gentoo.org | ||
| In Reply to: | [gentoo-portage-dev] [PATCH v2] Respect nonfatal in unpack(), econf() and einstall() by "Michał Górny" |
||
| 1 | On 11/30/2014 09:36 AM, Michał Górny wrote: |
| 2 | > @@ -628,7 +665,11 @@ einstall() { |
| 3 | > sysconfdir="${ED}etc" \ |
| 4 | > ${LOCAL_EXTRA_EINSTALL} \ |
| 5 | > ${MAKEOPTS} -j1 \ |
| 6 | > - "$@" ${EXTRA_EMAKE} install || die "einstall failed" |
| 7 | > + "$@" ${EXTRA_EMAKE} install |
| 8 | > + then |
| 9 | > + __helpers_die "einstall failed" |
| 10 | > + return 1 |
| 11 | > + fi |
| 12 | > else |
| 13 | > die "no Makefile found" |
| 14 | > fi |
| 15 | > |
| 16 | |
| 17 | The patch all looks good to me. However, the last die shown in the diff |
| 18 | context here makes me wonder why that one wasn't converted from die to |
| 19 | __helpers_die. |
| 20 | -- |
| 21 | Thanks, |
| 22 | Zac |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [PATCH v2] Respect nonfatal in unpack(), econf() and einstall() | "Michał Górny" <mgorny@g.o> |