| 1 |
Dnia 2014-11-30, o godz. 11:26:16 |
| 2 |
Zac Medico <zmedico@g.o> napisał(a): |
| 3 |
|
| 4 |
> On 11/30/2014 09:36 AM, Michał Górny wrote: |
| 5 |
> > @@ -628,7 +665,11 @@ einstall() { |
| 6 |
> > sysconfdir="${ED}etc" \ |
| 7 |
> > ${LOCAL_EXTRA_EINSTALL} \ |
| 8 |
> > ${MAKEOPTS} -j1 \ |
| 9 |
> > - "$@" ${EXTRA_EMAKE} install || die "einstall failed" |
| 10 |
> > + "$@" ${EXTRA_EMAKE} install |
| 11 |
> > + then |
| 12 |
> > + __helpers_die "einstall failed" |
| 13 |
> > + return 1 |
| 14 |
> > + fi |
| 15 |
> > else |
| 16 |
> > die "no Makefile found" |
| 17 |
> > fi |
| 18 |
> > |
| 19 |
> |
| 20 |
> The patch all looks good to me. However, the last die shown in the diff |
| 21 |
> context here makes me wonder why that one wasn't converted from die to |
| 22 |
> __helpers_die. |
| 23 |
|
| 24 |
Because it's incorrect use, not a call failure :). I have decided to |
| 25 |
use __helpers_die whenever the executed command fails but force die |
| 26 |
on asserts and invalid uses. |
| 27 |
|
| 28 |
-- |
| 29 |
Best regards, |
| 30 |
Michał Górny |
Archives