Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] Add missing bind for pkg_nofetch
Date: Thu, 25 Sep 2014 18:13:07
Message-Id: 54245B23.50303@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] Add missing bind for pkg_nofetch by "Michał Górny"
1 On 09/24/2014 10:48 PM, Michał Górny wrote:
2 > Spotted-by: Zac Medico <zmedico@g.o>
3 > ---
4 > bin/phase-functions.sh | 2 ++
5 > 1 file changed, 2 insertions(+)
6 >
7 > diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh
8 > index 9117719..d292ad3 100644
9 > --- a/bin/phase-functions.sh
10 > +++ b/bin/phase-functions.sh
11 > @@ -807,6 +807,8 @@ __ebuild_phase_funcs() {
12 > default_src_compile() { __eapi2_src_compile; }
13 >
14 > # bind supported phases to the defaults
15 > + declare -F pkg_nofetch >/dev/null || \
16 > + pkg_nofetch() { default; }
17 > declare -F src_unpack >/dev/null || \
18 > src_unpack() { default; }
19 > declare -F src_prepare >/dev/null || \
20 >
21
22 LGTM. I'm pretty sure there are no other issues with
23 772ed29fd9e7cf722aed943adbe33a27f250e1ff, so I'd say we should go ahead
24 and merge it with these 2 fixes.
25 --
26 Thanks,
27 Zac

Replies