Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] Add missing bind for pkg_nofetch
Date: Thu, 25 Sep 2014 18:31:16
Message-Id: 20140925113053.188a0c7e.dolsen@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] Add missing bind for pkg_nofetch by Zac Medico
1 On Thu, 25 Sep 2014 11:12:51 -0700
2 Zac Medico <zmedico@g.o> wrote:
3
4 > On 09/24/2014 10:48 PM, Michał Górny wrote:
5 > > Spotted-by: Zac Medico <zmedico@g.o>
6 > > ---
7 > > bin/phase-functions.sh | 2 ++
8 > > 1 file changed, 2 insertions(+)
9 > >
10 > > diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh
11 > > index 9117719..d292ad3 100644
12 > > --- a/bin/phase-functions.sh
13 > > +++ b/bin/phase-functions.sh
14 > > @@ -807,6 +807,8 @@ __ebuild_phase_funcs() {
15 > > default_src_compile()
16 > > { __eapi2_src_compile; }
17 > > # bind supported phases to the defaults
18 > > + declare -F pkg_nofetch >/dev/null || \
19 > > + pkg_nofetch() { default; }
20 > > declare -F src_unpack >/dev/null || \
21 > > src_unpack() { default; }
22 > > declare -F src_prepare >/dev/null || \
23 > >
24 >
25 > LGTM. I'm pretty sure there are no other issues with
26 > 772ed29fd9e7cf722aed943adbe33a27f250e1ff, so I'd say we should go
27 > ahead and merge it with these 2 fixes.
28
29 yeah, my thought too.
30
31 It's also why I was bugging him to get this fixed, so we could re-apply
32 it all.
33
34 --
35 Brian Dolbec <dolsen>

Replies