Re: [gentoo-portage-dev] [PATCH] Add missing bind for pkg_nofetch

[Brian Dolbec]

On Thu, 25 Sep 2014 11:30:53 -0700
Brian Dolbec <dolsen@g.o> wrote:

> On Thu, 25 Sep 2014 11:12:51 -0700
> Zac Medico <zmedico@g.o> wrote:
>
> > On 09/24/2014 10:48 PM, Michał Górny wrote:
> > > Spotted-by: Zac Medico <zmedico@g.o>
> > > ---
> > >  bin/phase-functions.sh | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh
> > > index 9117719..d292ad3 100644
> > > --- a/bin/phase-functions.sh
> > > +++ b/bin/phase-functions.sh
> > > @@ -807,6 +807,8 @@ __ebuild_phase_funcs() {
> > >  				default_src_compile()
> > > { __eapi2_src_compile; }
> > >  			# bind supported phases to the defaults
> > > +			declare -F pkg_nofetch >/dev/null || \
> > > +				pkg_nofetch() { default; }
> > >  			declare -F src_unpack >/dev/null || \
> > >  				src_unpack() { default; }
> > >  			declare -F src_prepare >/dev/null || \
> > >
> >
> > LGTM. I'm pretty sure there are no other issues with
> > 772ed29fd9e7cf722aed943adbe33a27f250e1ff, so I'd say we should go
> > ahead and merge it with these 2 fixes.
>
> yeah, my thought too.
>
> It's also why I was bugging him to get this fixed, so we could
> re-apply it all.
>

committed all 3 patches merged into one commit.

-- 
Brian Dolbec <dolsen>