Archives
Archives
| From: | Michael 'veremitz' Everitt <gentoo@×××××××.xyz> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH gentoolkit 1/2] eclean: Rewrite findPackages() | ||
| Date: | Fri, 21 Feb 2020 05:36:52 | ||
| Message-Id: | 5e0790cc-cc1a-1543-a48c-8e4a01c133ee@veremit.xyz | ||
| In Reply to: | [gentoo-portage-dev] [PATCH gentoolkit 1/2] eclean: Rewrite findPackages() by Matt Turner |
||
| 1 | On 21/02/20 05:29, Matt Turner wrote: |
| 2 | > I found the original code to be nearly incomprehensible. Instead of |
| 3 | > populating a dict of potential binpkgs to remove and then removing from |
| 4 | > the to-be-removed list, just selectively add to-be-removed packages. |
| 5 | > |
| 6 | > Signed-off-by: Matt Turner <mattst88@g.o> |
| 7 | > --- |
| 8 | > I switched from tabs to spaces in the process. I can revert back if |
| 9 | > desired. |
| 10 | > |
| 11 | Probably best to stick to tabs for consistency with the other portage code, |
| 12 | although naturally Zac probably better to ACK/NACK that. |
| 13 | |
| 14 | Otherwise I think this is a good refresh. +1. |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-portage-dev] [PATCH gentoolkit 1/2] eclean: Rewrite findPackages() | Zac Medico <zmedico@g.o> |