Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] portageq: fix eroot parameter (bug #529200)
Date: Fri, 14 Nov 2014 08:57:37
Message-Id: 5465C3F8.4090700@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] portageq: fix eroot parameter (bug #529200) by Zac Medico
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 14/11/14 08:42, Zac Medico wrote:
5 > + eprefix = os.environ.get("EPREFIX", portage.const.EPREFIX)
6 > + if eprefix:
7 > + eprefix = portage.util.normalize_path(eprefix)
8 Why not just:
9 eprefix = os.environ.get("EPREFIX", portage.const.EPREFIX) and \
10 portage.util.normalize_path(eprefix)
11 ?
12
13 I don't care *that* much. Patch looks good otherwise, so go ahead & merge,
14 with or without my proposed change.
15 - --
16 Alexander
17 bernalex@g.o
18 https://secure.plaimi.net/~alexander
19 -----BEGIN PGP SIGNATURE-----
20 Version: GnuPG v2
21 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
22
23 iF4EAREIAAYFAlRlw/gACgkQRtClrXBQc7VfNgEAlDyhLlgp8kagXSfFbLyQFjWS
24 RsE7bGdLkulDbOO4oR4BAIuKxwFKx7yUkregTqiyS7aNX7jdQcY3YhOAdcHte0Cw
25 =7o+I
26 -----END PGP SIGNATURE-----

Replies