Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] portageq: fix eroot parameter (bug #529200)
Date: Fri, 14 Nov 2014 17:36:39
Message-Id: 54663D9F.4020008@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] portageq: fix eroot parameter (bug #529200) by Alexander Berntsen
1 On 11/14/2014 12:57 AM, Alexander Berntsen wrote:
2 > On 14/11/14 08:42, Zac Medico wrote:
3 >> + eprefix = os.environ.get("EPREFIX", portage.const.EPREFIX)
4 >> + if eprefix:
5 >> + eprefix = portage.util.normalize_path(eprefix)
6 > Why not just:
7 > eprefix = os.environ.get("EPREFIX", portage.const.EPREFIX) and \
8 > portage.util.normalize_path(eprefix)
9 > ?
10
11 That won't work, because you can't reference eprefix on the right hand
12 side of the assignment, and the whole right hand side must evaluate
13 before the eprefix reference is initialized.
14
15 > I don't care *that* much. Patch looks good otherwise, so go ahead & merge,
16 > with or without my proposed change.
17 >
18
19 Merged, thanks.
20
21 --
22 Thanks,
23 Zac

Replies

Subject Author
Re: [gentoo-portage-dev] [PATCH] portageq: fix eroot parameter (bug #529200) Alexander Berntsen <bernalex@g.o>