Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 2/2] repoman: Enable testing exp profiles by default
Date: Thu, 11 Jan 2018 04:10:42
Message-Id: 1515643833.1368.2.camel@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH 2/2] repoman: Enable testing exp profiles by default by Mike Gilbert
1 W dniu śro, 10.01.2018 o godzinie 21∶45 -0500, użytkownik Mike Gilbert
2 napisał:
3 > On Wed, Jan 10, 2018 at 5:56 PM, Zac Medico <zmedico@g.o> wrote:
4 > > On 01/10/2018 02:24 PM, Michał Górny wrote:
5 > > > Enable repoman checks on exp profiles by default to improve
6 > > > the dependency graph integrity on those profiles and help them on their
7 > > > way towards stable status. This is possible now that the dependency
8 > > > graph problems are warnings rather than errors.
9 > > > ---
10 > > > repoman/pym/repoman/argparser.py | 2 +-
11 > > > 1 file changed, 1 insertion(+), 1 deletion(-)
12 > > >
13 > > > diff --git a/repoman/pym/repoman/argparser.py b/repoman/pym/repoman/argparser.py
14 > > > index f32972288..d49147366 100644
15 > > > --- a/repoman/pym/repoman/argparser.py
16 > > > +++ b/repoman/pym/repoman/argparser.py
17 > > > @@ -167,7 +167,7 @@ def parse_args(argv, qahelp, repoman_default_opts):
18 > > >
19 > > > parser.add_argument(
20 > > > '-e', '--include-exp-profiles', choices=('y', 'n'), metavar='<y|n>',
21 > > > - default=False,
22 > > > + default='y',
23 > > > help='include exp profiles in dependency checks')
24 > > >
25 > > > parser.add_argument(
26 > > >
27 > >
28 > > We have dev and exp profiles disabled by default because the time
29 > > consumed by repoman is proportional to the number of profiles.
30 > >
31 > > The current counts are as follows:
32 > >
33 > > stable 87
34 > > dev 88
35 > > exp 149
36 >
37 > Yeah, I really don't like the idea of making repoman even slower by default.
38
39 The alternative is to go for all profiles being stable. Because
40 accepting developers randomly breaking profiles 'because repoman speed'
41 is not acceptable.
42
43 >
44 > Also, I'm not sure why exp profiles are to be treated as more stable
45 > than dev profiles. I was always under the impression that the reverse
46 > was true, though I cannot recall where that assumption was formed.
47
48 A lot of people have different impressions, and noone really ever
49 bothered trying to document what means what. 'exp' is easier to change
50 because the argument takes y/n, so '-e n' can easily be done by user,
51 unlike '-d' that is pure boolean flag.
52
53 >
54 > I would like to see this formally documented somewhere before we start
55 > changing repoman defaults.
56
57 It's part of my proposal for Sunday's Council meeting.
58
59 --
60 Best regards,
61 Michał Górny

Replies