| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA512 |
| 3 |
|
| 4 |
I read through these ages ago, and I think you've incorporated my |
| 5 |
feedback from back then. But like back then, I don't have too much |
| 6 |
feedback to offer as this is certainly not an area of Portage I'm |
| 7 |
nearly as familiar with as you are. It mostly just LGTM. |
| 8 |
|
| 9 |
There are some minor issues with commit messages. Like how they |
| 10 |
randomly don't have full stops in some sentences for some reason. |
| 11 |
"fetches.py: Create new isVcsDir() in the vcs plugins" says "teh" |
| 12 |
instead of "the". |
| 13 |
|
| 14 |
ThirdPartyMirrors is a bit low on documentation. |
| 15 |
|
| 16 |
I expect Zac will be of far more help than me. In any event, thanks a |
| 17 |
lot for working on this! |
| 18 |
|
| 19 |
|
| 20 |
You asked about a release on IRC -- did you want to get a release out |
| 21 |
before merging this? I would be fine with either way. Let me know what |
| 22 |
you need from me, and I'll get on it ASAP. |
| 23 |
- -- |
| 24 |
Alexander |
| 25 |
bernalex@g.o |
| 26 |
https://secure.plaimi.net/~alexander |
| 27 |
-----BEGIN PGP SIGNATURE----- |
| 28 |
Version: GnuPG v2 |
| 29 |
|
| 30 |
iQIcBAEBCgAGBQJWk8yvAAoJENQqWdRUGk8BgVMQAJXFEpIHZ++Cp08rJ4RQhwJr |
| 31 |
MgAqqpfSO54KKuAQTQ0FZLpWI698YtrIRWMMo9cysJCW9usCgFp/TaB6k78ci/2/ |
| 32 |
NSu+LRhS4MjP+aZG/RiIcXThUQCTVWOFD3T5InWEek8i2Gasc8nZVNjZhHUn/G/R |
| 33 |
mRMEU0utsv8oueIX1XSYeQfW9jtD5HLJlpF4LEFSHufpzQA7ZJyy63URU/FmP3Tt |
| 34 |
n4Z6KRCzzxQEpv8UFG7bFjTS4rSUfZ1EXsmGuAbc33G+ZM7kQFsb86SKhLLDmAOv |
| 35 |
bOamyjhHWW5jRk7+R1O7lWNwZrisfTGLVWPRj8CjFko+Bl9bXjwKpQEzGPNTpOPe |
| 36 |
ocbjilxvhRoOoKJ945Q5ylsYfHGZD2uPyuSRM03KJHCptRsgM99zrrbCKakw8Aht |
| 37 |
DGfJlKcVrysrbR8NdmI/a5hBq6p7LqAYiPxXTfCwjexooEF6aMVxr1HGRabZMeeu |
| 38 |
aJdbmb6Ajk4i4b7xDzPpofivENdTTLwZrG+pi/0ZaEI0xvw1JiI1FGm7VLiHh2Oe |
| 39 |
GBJoKl/JQa63QJivJIL83OtUT4FYP3ZOnWSuhHj/p1LtzAyJU+FptjhCHlFdnl32 |
| 40 |
79ML0g/7RJAB8ackxCeruF8laclKIvKJNhwBYXbGzhOpmjU4Gp/fo6HieQBWvBlo |
| 41 |
CMfX/Ufv6M5gfgVgDJf1 |
| 42 |
=18rr |
| 43 |
-----END PGP SIGNATURE----- |
Archives