Re: [gentoo-project] Re: EAPI6 Features

[Ulrich Mueller]

>>>>> On Mon, 9 Jun 2014, Michał Górny wrote:

> Dnia 2014-06-09, o godz. 18:23:21
> Ulrich Mueller <ulm@g.o> napisał(a):

>> As I said before, I believe that the package manager shouldn't
>> perform any magic operations between src_* phases. Calling
>> eapply_user like this is effectively an additional phase, so it's
>> conceptually cleaner to make it a regular phase function (e.g.,
>> src_userpatch) which would be called between src_prepare and
>> src_postpatch.

> Sounds insanely complex for a minor issue. What's the problem with
> ebuilds calling 'default' in src_prepare() to get user patches
> applied (and possibly ${PATCHES[@]} as well)?

Calling it in src_prepare() is perfectly fine with me. The only thing
I'm saying is that we shouldn't call eapply_user outside of a phase
function, whatever that phase function will be.

Ulrich