| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA512 |
| 3 |
|
| 4 |
On 06/09/2014 10:31 AM, Ian Stakenvicius wrote: |
| 5 |
> On 08/06/14 09:04 AM, Rich Freeman wrote: |
| 6 |
>> Most of the proposed EAPI6 features seem ripe for acceptance, |
| 7 |
>> but I figured I'd comment on a few here in case others want to |
| 8 |
>> weigh in. |
| 9 |
>>> b) User patches Bug #475288 [15], PMS wording [16] - Needs 4a) |
| 10 |
>>> - Current wording of the spec requires that every ebuild must |
| 11 |
>>> include a call to the function in src_prepare, which is |
| 12 |
>>> controversial. - Names "apply_user_patches" or "eapply_user" |
| 13 |
>>> have been suggested. |
| 14 |
>>> |
| 15 |
> |
| 16 |
>> I'm generally fine with it (we can bikeshed the name to death |
| 17 |
>> later), but is there any reason to not just simply apply the |
| 18 |
>> patches after src_prepare is done and not make maintainers call |
| 19 |
>> it? If we're concerned about sequencing with other activities in |
| 20 |
>> src_prepare then that is fine - I don't have a big problem with |
| 21 |
>> it being a fatal error if it doesn't get called. |
| 22 |
> |
| 23 |
> |
| 24 |
> General guidelines for epatch_user is that it should be placed |
| 25 |
> after all ${S} manipulation but before eautoreconf. Otherwise |
| 26 |
> anything that modifies configure.ac won't take effect. |
| 27 |
> |
| 28 |
> If src_prepare is defined, that would mean it'd have to be put |
| 29 |
> right in the middle, still. If it isn't defined, then either an |
| 30 |
> eclass would need to handle it as appropriate (i think many do; |
| 31 |
> autotools-utils.eclass iirc has some code for this?), or the |
| 32 |
> default src_prepare phase function would need to get a -lot- more |
| 33 |
> complicated in order to handle patches that touch certain |
| 34 |
> build-systems. |
| 35 |
> |
| 36 |
> Or would we just ban build-system patches from user patches? |
| 37 |
> |
| 38 |
> |
| 39 |
|
| 40 |
Just as a thought, perhaps we might add another phase, named like |
| 41 |
"src_postpatch" (open to bikesheding), and have the `eapply_user` |
| 42 |
called automatically between src_prepare and src_postpatch. Any |
| 43 |
post-user patch code (like eautoreconf) would then go in src_postpatch. |
| 44 |
|
| 45 |
Thoughts? |
| 46 |
|
| 47 |
- -- |
| 48 |
Jonathan Callen |
| 49 |
-----BEGIN PGP SIGNATURE----- |
| 50 |
Version: GnuPG v2.0.22 (GNU/Linux) |
| 51 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 52 |
|
| 53 |
iQIcBAEBCgAGBQJTldLZAAoJELHSF2kinlg4RqQP/RviMdnLAGRAy60m+qEDWy3C |
| 54 |
ZvANn6sIjQtcXU37aX5Li1/7QC+RGqD6w7KLElJpL8D4MSL1ga8ORw5NY4VE+But |
| 55 |
XB7n8mpzZZpxU7IHxfZ4gLMmz4OHXDQP34LNmxzVffftU/+H9U0k7WKeNGLL4C1H |
| 56 |
ZBB8NkyLwGzlfIDQfCsFoDJCl5ebUi0ecijPVHOucuBwyPMTTJFg92fm8r/5vJ+C |
| 57 |
F+N0+LoGzyBX0G9Xp/Ygtd69wALxpqv05g4zRdpAu8WaBZ+2s6SiuBif3DIAFykC |
| 58 |
PurzfwSFqIk0rtF2p27W3WFAAXV7Zam1b7Kadw6BnrfZxmHsurgbvTHk5J309Z2S |
| 59 |
J+9P5oIH2dTzXhV9Npk0kRHoMPxOQWMeXRQ9f9fAmFgPyLnTzfLBgtAQMIdGba1W |
| 60 |
COnIk1Je3lfAv98NGv1hvZNOe8N8NbdSaf2kkfDFtppCVOHvaWVAhBQ0V0rJO92Q |
| 61 |
1i9h53XwTxOk6aKkUgOsiW/qgIvx8wgLuVKOJd5ADR/4FHvlJbjlI5b+K+eV07Vv |
| 62 |
wk/I8FsopEJdCX9r4oCecYRk1OwY5Xz+T8sZhrjQXISxQv38Byn8v+1h81MT/K2K |
| 63 |
a0l/BqAplRv7SRkB4hkJq/azK70dgulIFDN/aQiUgjgGxedjyPEMFLN2Sy10va6g |
| 64 |
bHYZ+Xwx7/pXIq5kXy9s |
| 65 |
=Bhve |
| 66 |
-----END PGP SIGNATURE----- |
Archives