Gentoo Archives: gentoo-project

From: "Michał Górny" <mgorny@g.o>
To: gentoo-project@l.g.o
Cc: Joonas Niilola <juippis@g.o>
Subject: Re: [gentoo-project] [RFC] glep-0076: add clarification about the sign-off requirements
Date: Wed, 28 Jul 2021 07:14:54
Message-Id: 31a6b534c584c8289851a9fab6e8aaca2115585d.camel@gentoo.org
In Reply to: [gentoo-project] [RFC] glep-0076: add clarification about the sign-off requirements by Joonas Niilola
1 On Wed, 2021-07-28 at 07:07 +0300, Joonas Niilola wrote:
2 > @@ -138,7 +139,10 @@ the Certificate of Origin by adding ::
3 >  
4 >  to the commit message as a separate line.  The sign-off must contain
5 >  the committer's legal name as a natural person, i.e., the name that
6 > -would appear in a government issued document.
7 > +would appear in a government issued document. It's strongly encouraged
8 > +that the original contribution author also adds their sign-off, to at
9 > +least indicate they are aware of this GLEP. But it's required only
10 > +from the committer.
11
12 To be honest, the wording sounds a bit backwards. 'Commiters must do X
13 but we encourage everyone to do X but it's only required from
14 committers.'
15
16 Let's maybe start by replacing 'the committer shall' with 'the committer
17 must'. As the next sentence, something akin 'Other authors contributing
18 to the change are also encouraged to include their sign-off but
19 the committer decides whether these sign-offs are required'. And then
20 the common part about real name, as it applies the same to both.
21
22 >  
23 >  The following is the current Gentoo Certificate of Origin, revision 1:
24 >  
25 > @@ -301,6 +305,9 @@ iv.  The original point (d) has been transformed into a stand-alone
26 >  v.   The term "open source" has been replaced by "free software"
27 >       throughout.
28 >  
29 > +vi.  Clarify that a sign-off is only strictly required from the
30 > +     committer, not from the author.
31 > +
32 >  The new point was deemed necessary to allow committing license files
33 >  into the Gentoo repository, since those files usually do not permit
34 >  modification.  It has been established that adding a clear provision
35
36 --
37 Best regards,
38 Michał Górny

Replies