Archives
Archives
| From: | Joonas Niilola <juippis@g.o> | ||
|---|---|---|---|
| To: | gentoo-proxy-maint@l.g.o | ||
| Subject: | Re: [gentoo-proxy-maint] [PATCH 1/2] app-editors/vis: Add -fcommon | ||
| Date: | Sat, 06 Jun 2020 16:38:43 | ||
| Message-Id: | 801095d3-fa20-bda6-0364-eb9bb95c72de@gentoo.org | ||
| In Reply to: | Re: [gentoo-proxy-maint] [PATCH 1/2] app-editors/vis: Add -fcommon by Joonas Niilola |
||
| 1 | On 5/15/20 4:24 PM, Joonas Niilola wrote: |
| 2 | > On 5/11/20 12:38 AM, Haelwenn (lanodan) Monnier wrote: |
| 3 | >> } |
| 4 | >> |
| 5 | >> src_configure() { |
| 6 | >> + export CFLAGS="$CFLAGS -fcommon" # https://github.com/martanne/vis-test/issues/21 |
| 7 | > Let's use the recommended style, |
| 8 | > |
| 9 | > https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common#The_-fcommon_workaround_.28discouraged.29 |
| 10 | > |
| 11 | > |
| 12 | You could've just told me it doesn't carry on to test phase. Although |
| 13 | still not happy with it (use {} around variables), merged as |
| 14 | |
| 15 | https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b015f553ce6b600fd938f381faee5429270d402c |
| 16 | |
| 17 | https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0615eb3242d0bea42719bea4f34fbcb75a14af5 |
| 18 | |
| 19 | -9999 seems to have been already fixed by upstream so not touching that |
| 20 | this time. |
| 21 | |
| 22 | -- juippis |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |