Re: [gentoo-proxy-maint] [PATCH 1/2] app-editors/vis: Add -fcommon

[Joonas Niilola]

On 5/11/20 12:38 AM, Haelwenn (lanodan) Monnier wrote:
> Closes: https://bugs.gentoo.org/716312
> Signed-off-by: Haelwenn (lanodan) Monnier <contact@×××××××××.me>
> ---
>  app-editors/vis/vis-0.5.ebuild  | 2 ++
>  app-editors/vis/vis-9999.ebuild | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/app-editors/vis/vis-0.5.ebuild b/app-editors/vis/vis-0.5.ebuild
> index 08274f3b376..ffaeafaa266 100644
> --- a/app-editors/vis/vis-0.5.ebuild
> +++ b/app-editors/vis/vis-0.5.ebuild
> @@ -42,6 +42,8 @@ src_prepare() {
>  }
>
>  src_configure() {
> +	export CFLAGS="$CFLAGS -fcommon" # https://github.com/martanne/vis-test/issues/21

Let's use the recommended style,

https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common#The_-fcommon_workaround_.28discouraged.29


> +
>  	./configure \
>  		--prefix="${EPREFIX}"/usr \
>  		--docdir="${EPREFIX}"/usr/share/doc/${PF} \
> diff --git a/app-editors/vis/vis-9999.ebuild b/app-editors/vis/vis-9999.ebuild
> index 72ff783c840..6832624fb6b 100644
> --- a/app-editors/vis/vis-9999.ebuild
> +++ b/app-editors/vis/vis-9999.ebuild
> @@ -34,6 +34,8 @@ src_prepare() {
>  }
>
>  src_configure() {
> +	export CFLAGS="$CFLAGS -fcommon" # https://github.com/martanne/vis-test/issues/21
> +

Here too.

-- juippis