1 |
On 12/6/18 10:28 AM, Corentin “Nado” Pazdera wrote: |
2 |
> December 5, 2018 11:35 PM, "Vieri" <rentorbuy@×××××.com> wrote: |
3 |
> |
4 |
>> On Wednesday, December 5, 2018, 11:19:38 PM GMT+1, Corentin “Nado” Pazdera <nado@××××××××××.be> |
5 |
>> wrote: |
6 |
>> There's a trivial change I'd like to apply to the samba ebuilds. I'd like to restore something that |
7 |
>> was mysteriously removed years ago: pam winbind authentication configuration file. |
8 |
>> More here: |
9 |
>> https://bugs.gentoo.org/590374 |
10 |
>> and here: https://590374.bugs.gentoo.org/attachment.cgi?id=496430 |
11 |
>> |
12 |
>> This is what I did with git, but I think I messed up because maybe I should have edited the |
13 |
>> existing ebuilds instead of creating another revision (my change is not critical, does not affect |
14 |
>> in any way users using the previous ebuilds; however, it does "install additional files that could |
15 |
>> be useful to the user"): |
16 |
>> |
17 |
>> https://github.com/gentoo/gentoo/pull/10578 |
18 |
> Well, it impacts dependency calculation for a new useflag, I *think* (still no expert), revbump is advised here. |
19 |
> Also, I think a useless revbump is better than an absent one causing tree breakage ;) |
20 |
> |
21 |
> Corentin “Nado” Pazdera |
22 |
> |
23 |
|
24 |
If you introduce a new IUSE, you don't have to revbump because people |
25 |
running 'emerge -uavDN world' will be hit by that change. This kind of |
26 |
modification without new IUSE is a revbump though. |
27 |
|
28 |
|
29 |
But in this case, 4.8.6-r2 is stabilized, so you can't touch it with |
30 |
this. So in this case, it's a revbump, as you've done. |