Gentoo Archives: gentoo-python

From: Mike Gilbert <floppym@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-python@l.g.o, python@g.o
Subject: [gentoo-python] Re: [PATCH] Export best implementation build dir as BUILD_DIR in common phases.
Date: Sat, 12 Jan 2013 21:30:08
Message-Id: 50F1B3BC.6040709@gentoo.org
In Reply to: [gentoo-python] [PATCH] Export best implementation build dir as BUILD_DIR in common phases. by "Michał Górny"
1 On 01/12/2013 01:52 PM, Michał Górny wrote:
2 > This is more friendly than BEST_BUILD_DIR and should not cause trouble
3 > in the common cases.
4 > ---
5 > gx86/eclass/distutils-r1.eclass | 4 +++-
6 > 1 file changed, 3 insertions(+), 1 deletion(-)
7 >
8 > diff --git a/gx86/eclass/distutils-r1.eclass b/gx86/eclass/distutils-r1.eclass
9 > index 8156a36..9d6c714 100644
10 > --- a/gx86/eclass/distutils-r1.eclass
11 > +++ b/gx86/eclass/distutils-r1.eclass
12 > @@ -450,9 +450,11 @@ distutils-r1_run_phase() {
13 > # @DESCRIPTION:
14 > # Run the given command, restoring the best-implementation state.
15 > _distutils-r1_run_common_phase() {
16 > + local DISTUTILS_ORIG_BUILD_DIR=${BUILD_DIR}
17 > +
18 > local EPYTHON=${_DISTUTILS_BEST_IMPL[0]}
19 > local PYTHON=${_DISTUTILS_BEST_IMPL[1]}
20 > - local BEST_BUILD_DIR=${_DISTUTILS_BEST_IMPL[2]}
21 > + local BUILD_DIR=${_DISTUTILS_BEST_IMPL[2]}
22 > local PYTHONPATH=${_DISTUTILS_BEST_IMPL[3]}
23 >
24 > export EPYTHON PYTHON PYTHONPATH
25 >
26
27 I never really understood the point of BEST_BUILD_DIR anyway. Did
28 anything ever use it?
29
30 The change seems ok.

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies