1 |
On Sat, 12 Jan 2013 14:04:28 -0500 |
2 |
Mike Gilbert <floppym@g.o> wrote: |
3 |
|
4 |
> On 01/12/2013 01:52 PM, Michał Górny wrote: |
5 |
> > This is more friendly than BEST_BUILD_DIR and should not cause trouble |
6 |
> > in the common cases. |
7 |
> > --- |
8 |
> > gx86/eclass/distutils-r1.eclass | 4 +++- |
9 |
> > 1 file changed, 3 insertions(+), 1 deletion(-) |
10 |
> > |
11 |
> > diff --git a/gx86/eclass/distutils-r1.eclass b/gx86/eclass/distutils-r1.eclass |
12 |
> > index 8156a36..9d6c714 100644 |
13 |
> > --- a/gx86/eclass/distutils-r1.eclass |
14 |
> > +++ b/gx86/eclass/distutils-r1.eclass |
15 |
> > @@ -450,9 +450,11 @@ distutils-r1_run_phase() { |
16 |
> > # @DESCRIPTION: |
17 |
> > # Run the given command, restoring the best-implementation state. |
18 |
> > _distutils-r1_run_common_phase() { |
19 |
> > + local DISTUTILS_ORIG_BUILD_DIR=${BUILD_DIR} |
20 |
> > + |
21 |
> > local EPYTHON=${_DISTUTILS_BEST_IMPL[0]} |
22 |
> > local PYTHON=${_DISTUTILS_BEST_IMPL[1]} |
23 |
> > - local BEST_BUILD_DIR=${_DISTUTILS_BEST_IMPL[2]} |
24 |
> > + local BUILD_DIR=${_DISTUTILS_BEST_IMPL[2]} |
25 |
> > local PYTHONPATH=${_DISTUTILS_BEST_IMPL[3]} |
26 |
> > |
27 |
> > export EPYTHON PYTHON PYTHONPATH |
28 |
> > |
29 |
> |
30 |
> I never really understood the point of BEST_BUILD_DIR anyway. Did |
31 |
> anything ever use it? |
32 |
|
33 |
Well, the one ebuild that needed distutils BUILD_DIR. |
34 |
|
35 |
The major issue is that BUILD_DIR is used in python_foreach_impl to |
36 |
construct implementation-specific BUILD_DIRs. It's an unlikely scenario |
37 |
but it will be a bit broken if anything in python_*_all() used |
38 |
python_foreach_impl() and BUILD_DIR set by it. |
39 |
|
40 |
-- |
41 |
Best regards, |
42 |
Michał Górny |