Gentoo Archives: gentoo-releng

From: Ben Kohler <bkohler@×××××.com>
To: gentoo-releng@l.g.o
Subject: Re: [gentoo-releng] [PATCH] s390: mv flat package.keywords file to package.accept_keywords dir
Date: Tue, 13 Mar 2018 13:34:07
Message-Id: CANSUr=KkoMh2ETKYfiX7mCR7J0Nk8wpLgMn0Mb-wF7d7WERhfQ@mail.gmail.com
In Reply to: Re: [gentoo-releng] [PATCH] s390: mv flat package.keywords file to package.accept_keywords dir by "Jorge Manuel B. S. Vicetto"
1 Yeah, when troubleshooting the portage_prefix code last time I made
2 sure that the "new" p.a_k location was in the cleanup list.
3 Eventually I'd like to rename all package.keywords dirs in the repo to
4 package.accept_keywords, since this has been the official correct
5 location for many years now.
6
7 -Ben
8
9 On Tue, Mar 13, 2018 at 8:23 AM, Jorge Manuel B. S. Vicetto
10 <jmbsvicetto@g.o> wrote:
11 > Hi Ben.
12 >
13 > On Tue, Mar 13, 2018 at 12:08 PM, Ben Kohler <bkohler@×××××.com> wrote:
14 >> Attached is a small mv-only patch to fix recent s390 netboot build
15 >> failures. Please review.
16 >>
17 >> -Ben
18 >
19 > There was only one potential issue I could see with that change, but
20 > I've now confirmed it isn't a problem. We have hard coded the
21 > directory names for doing the "cleaning", but we have both
22 > package.accept_keywords and package.keywords in that list.
23 > https://gitweb.gentoo.org/proj/catalyst.git/tree/catalyst/base/stagebase.py
24 > line 1221
25 >
26 > BTW, I just noticed the following typo in line 1220 "portage_preix":
27 > log.debug("clean(), portage_preix = %s, no sticky-config",
28 > self.settings["portage_prefix"])
29 >
30 > Please grant S390 (vapier?) until the weekend to reply. If there's no
31 > reply or if they agree, feel free to commit the change.
32 > Thanks,
33 >
34 > Jorge
35 >