Gentoo Archives: gentoo-releng

From: "Jorge Manuel B. S. Vicetto" <jmbsvicetto@g.o>
To: gentoo-releng@l.g.o
Cc: s390@g.o
Subject: Re: [gentoo-releng] [PATCH] s390: mv flat package.keywords file to package.accept_keywords dir
Date: Tue, 13 Mar 2018 13:23:07
Message-Id: CADvE9N=piu3JpC=c2-LcfyFQBXUjO6mpO=dqBcTNqwRYVX9GEQ@mail.gmail.com
In Reply to: [gentoo-releng] [PATCH] s390: mv flat package.keywords file to package.accept_keywords dir by Ben Kohler
1 Hi Ben.
2
3 On Tue, Mar 13, 2018 at 12:08 PM, Ben Kohler <bkohler@×××××.com> wrote:
4 > Attached is a small mv-only patch to fix recent s390 netboot build
5 > failures. Please review.
6 >
7 > -Ben
8
9 There was only one potential issue I could see with that change, but
10 I've now confirmed it isn't a problem. We have hard coded the
11 directory names for doing the "cleaning", but we have both
12 package.accept_keywords and package.keywords in that list.
13 https://gitweb.gentoo.org/proj/catalyst.git/tree/catalyst/base/stagebase.py
14 line 1221
15
16 BTW, I just noticed the following typo in line 1220 "portage_preix":
17 log.debug("clean(), portage_preix = %s, no sticky-config",
18 self.settings["portage_prefix"])
19
20 Please grant S390 (vapier?) until the weekend to reply. If there's no
21 reply or if they agree, feel free to commit the change.
22 Thanks,
23
24 Jorge

Replies