Gentoo Archives: gentoo-soc

From: brahmajit.xyz@×××××.com
To: gentoo-soc@l.g.o
Subject: [gentoo-soc] [GSoC] [WIP PATCH] build mp3info on musl profile
Date: Sat, 12 Mar 2022 11:14:56
Message-Id: 20220312111454.sz237tee76jtjzfw@gmail.com
1 This patch fixes bug 828919. Initially package mp3info could not be
2 built with musl with error `uint undeclared`. The fix is to move to
3 `usinged int` from `uint` (thanks to *sam_*). The extra `-lintfo` is
4 because it was failing to build with only `-lncurses`, I'm guessing this
5 due to incorrect USE flags on my system.
6
7 I'm hoping to get started with this simple patch and get reviews from
8 maintainers.
9
10 ---
11 diff --git a/Makefile b/Makefile
12 index e4e632d..e970f05 100644
13 --- a/Makefile
14 +++ b/Makefile
15 @@ -43,7 +43,7 @@ RM = /bin/rm
16 INSTALL = /usr/bin/install -c
17 STRIP = strip
18
19 -LIBS = -lncurses
20 +LIBS = -lncurses -ltinfo
21 CC = gcc
22 CFLAGS = -g -O2 -Wall
23
24 diff --git a/mp3tech.c b/mp3tech.c
25 index a1ae218..710491d 100644
26 --- a/mp3tech.c
27 +++ b/mp3tech.c
28 @@ -279,7 +279,7 @@ char *header_mode(mp3header *h) {
29 }
30
31 int sameConstant(mp3header *h1, mp3header *h2) {
32 - if((*(uint*)h1) == (*(uint*)h2)) return 1;
33 + if((*(unsigned int*)h1) == (*(unsigned int*)h2)) return 1;
34
35 if((h1->version == h2->version ) &&
36 (h1->layer == h2->layer ) &&
37 ---

Replies

Subject Author
Re: [gentoo-soc] [GSoC] [WIP PATCH] build mp3info on musl profile Fabian Groffen <grobian@g.o>