Re: [gentoo-soc] [GSoC] [WIP PATCH] build mp3info on musl profile

[Fabian Groffen]

On 12-03-2022 16:44:54 +0530, brahmajit.xyz@×××××.com wrote:
> This patch fixes bug 828919. Initially package mp3info could not be
> built with musl with error `uint undeclared`. The fix is to move to
> `usinged int` from `uint` (thanks to *sam_*). The extra `-lintfo` is
> because it was failing to build with only `-lncurses`, I'm guessing this
> due to incorrect USE flags on my system.
>
> I'm hoping to get started with this simple patch and get reviews from
> maintainers.
>
> ---
> diff --git a/Makefile b/Makefile
> index e4e632d..e970f05 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -43,7 +43,7 @@ RM = /bin/rm
>  INSTALL = /usr/bin/install -c
>  STRIP = strip
>
> -LIBS = -lncurses
> +LIBS = -lncurses -ltinfo

I think you don't want to do this unconditionally, perhaps you want to
call ncurses6-config --libs or pkg-config ncurses --libs to get the
necessary libraries.

>  CC = gcc
>  CFLAGS = -g -O2 -Wall
>
> diff --git a/mp3tech.c b/mp3tech.c
> index a1ae218..710491d 100644
> --- a/mp3tech.c
> +++ b/mp3tech.c
> @@ -279,7 +279,7 @@ char *header_mode(mp3header *h) {
>  }
>
>  int sameConstant(mp3header *h1, mp3header *h2) {
> -    if((*(uint*)h1) == (*(uint*)h2)) return 1;
> +    if((*(unsigned int*)h1) == (*(unsigned int*)h2)) return 1;

While this is an enormously dubious check (mp3header is a struct with as
first field an unsigned long), it seems from the code that this check
(whatever it may establish) is intended.

This change, for what's worth, is language wise the correct approach and
fully portable.

Thanks,
Fabian

>
>      if((h1->version       == h2->version         ) &&
>         (h1->layer         == h2->layer           ) &&
> ---
>

-- 
Fabian Groffen
Gentoo on a different level