| 1 |
The past weeks have been mainly about code review and fixing. |
| 2 |
|
| 3 |
[What we did] |
| 4 |
* Run both spec and cuucmber by default (committed by mentor Hans de Graaff) |
| 5 |
* Add role to User and related permission control facility |
| 6 |
* Ignored db/schema.rb and track db/migrations for schema-related stuff |
| 7 |
* Seed the dev database with db/seed.rb instead of rake db:bootstrap |
| 8 |
(avoided re-inventing wheels) |
| 9 |
* Fixed Agenda related bugs |
| 10 |
* gave credits to the original authors of some code lines |
| 11 |
* Found two bugs of Hobo and fixed them. Mentors have submitted |
| 12 |
patches upstream. |
| 13 |
* Adjust indention in all other files. |
| 14 |
|
| 15 |
* I worked on other tasks as well. But since they are not reviewed by |
| 16 |
mentors yet. I will write about them later. These tasks include: |
| 17 |
* GLEP work flow support in the application |
| 18 |
* Sending email notifications for new agenda item or approaching agenda |
| 19 |
|
| 20 |
|
| 21 |
[What to do] |
| 22 |
* Continue code review and fix any comments by mentors. |
| 23 |
* Self-check my previous code and try to fix any potential bugs |
| 24 |
|
| 25 |
[Problems] |
| 26 |
* The fixing progress has been very slow. I adopted a different editor |
| 27 |
configuration and many source code files have been affected (mainly |
| 28 |
indention related). I have to rebase to each commit and try to get it |
| 29 |
right. |
| 30 |
|
| 31 |
|
| 32 |
[Conclusion] |
| 33 |
The fixing stuff consumes much more time than I have expected. I will |
| 34 |
do some self-checking before pushing to remote repository as well in |
| 35 |
order to speed up the code review process. |
| 36 |
|
| 37 |
-- |
| 38 |
Xie, Wei |
Archives