Gentoo Archives: gentoo-dev

From: Andrey Utkin <andrey_utkin@××××××××.com>
To: gentoo-dev@l.g.o
Cc: Matthew Thode <prometheanfire@g.o>, Patrice Clement <monsieurp@g.o>, Wolfram Schlich <wschlich@g.o>
Subject: [gentoo-dev] Please retain authorship of contributed patches
Date: Wed, 30 Nov 2016 21:24:21
Message-Id: 20161130212356.GA27009@dell-m4800.home
1 I'm quite sure this angry rant won't be pleasant to read for anybody,
2 but still I believe this post serves the good of Gentoo and this issue
3 is technical enough to be discussed on gentoo-dev. Also gentoo-pr list
4 seems retired anyway.
5
6 This is a second time I've got into a situation when a new ebuild
7 submitted by me gets to mainline with minimal changes but not retaining
8 my authorship at all.
9
10 First time it was here: https://github.com/gentoo/gentoo/pull/361 and my
11 rant was endorsed by monsieurp and the committer made excuses.
12
13 This time the discussion between me and the committer has never
14 happened.
15
16 My PR: https://github.com/gentoo/gentoo/pull/2765
17
18 My bugzilla ticket linked to it:
19 https://bugs.gentoo.org/show_bug.cgi?id=599088
20
21 After my pull request from Nov 6, the following commit gets into mainline:
22
23 commit e19f46dfca967f4195eedf3f37a7882fbb37b796
24 Author: Matthew Thode <prometheanfire@g.o>
25 Date: Tue Nov 15 13:55:17 2016 -0600
26
27 dev-python/secretstorage: adding for keyring
28
29 Package-Manager: portage-2.3.0
30
31
32 The difference between my submission and final variant by Matthew is big
33 in number of lines, but is trivial in content as you can see below, so I
34 don't believe that Matthew has written his variant from scratch on his
35 own (he hasn't given any note on tickets on bugs.g.o or github), it
36 seems more like intentional swapping and amending original lines
37 retaining identical outcome.
38
39 Not that authorship of one or two commits is so crucial for me, or that
40 I'm the most ambitious wannabe-contributor. Hell, there's not much of
41 code at all in the ebuild - it's trivial; but also not much is needed
42 here to give credit. I have contributed to quite some FOSS projects, and
43 have run into theft of my patches a couple of times, and it never was by
44 pure accident.
45
46 I beg affiliated Gentoo developers to stay sane and be thinking not just
47 about numbers of your commits, but also about community spirit and
48 relationships. Of course inexperienced contributor gets things not right
49 first. In such cases, great maintainers fix that and retain original
50 authorship; good maintainers request for changes and resubmission.
51
52 In no way I'm going to drift away from Gentoo because of this issue, no
53 alternatives around. (I even have a gradually maturing idea to become
54 Gentoo contributor on regular basis.)
55
56 Just for record, a list of projects I've contributed to: FFmpeg, Linux
57 kernel, VLC, GStreamer, Kamailio, Mcabber, Gajim, v4l-utils.
58
59
60 diff --git a/336a45f661 b/98c5361d66
61 index 336a45f661..98c5361d66 100644
62 --- a/336a45f661
63 +++ b/98c5361d66
64 @@ -1,19 +1,27 @@
65 -# Copyright 2016 Gentoo Foundation
66 +# Copyright 1999-2016 Gentoo Foundation
67 # Distributed under the terms of the GNU General Public License v2
68 # $Id$
69
70 -EAPI="6"
71 -PYTHON_COMPAT=( python2_7 python3_{3,4,5} )
72 +EAPI=6
73 +PYTHON_COMPAT=( python{2_7,3_4,3_5} )
74
75 inherit distutils-r1
76
77 -DESCRIPTION="Python bindings to FreeDesktop.org Secret Service API"
78 -HOMEPAGE="http://pypi.python.org/pypi/SecretStorage"
79 -SRC_URI="mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz"
80 +MY_PN="SecretStorage"
81 +
82 +DESCRIPTION="Python bindings to FreeDesktop.org Secret Service API."
83 +HOMEPAGE="https://github.com/mitya57/secretstorage https://pypi.python.org/pypi/SecretStorage"
84 +SRC_URI="mirror://pypi/S/${MY_PN}/${MY_PN}-${PV}.tar.gz"
85
86 LICENSE="BSD"
87 SLOT="0"
88 -KEYWORDS="~amd64 ~x86"
89 +KEYWORDS="amd64 ~arm64 x86 ~amd64-linux ~x86-linux"
90 +IUSE=""
91 +
92 +DEPEND="dev-python/setuptools[${PYTHON_USEDEP}]"
93 +
94 +RDEPEND="
95 + dev-python/cryptography[${PYTHON_USEDEP}]
96 + dev-python/dbus-python[${PYTHON_USEDEP}]"
97
98 -RDEPEND="dev-python/dbus-python[${PYTHON_USEDEP}]
99 - dev-python/cryptography[${PYTHON_USEDEP}]"
100 +S="${WORKDIR}/${MY_PN}-${PV}"

Replies