Re: [gentoo-java] generation-2 java eclass

[Vlastimil Babka]

Alon Bar-Lev wrote:
> Looking at bug#146647, why did you remove the java from the IUSE? I

Because the eclass provides it already. Ebuild doesn't need to.

> don't think it is a clean to require programmer to define the
> JAVA_PKG_OPT_USE before the inherit... Or you need to add a BIG FAT
> WARNING at the eclass documentation/description.

You're getting it wrong. JAVA_PKG_OPT_USE is just a name for the flag 
that triggers java support. You need to specify it before inherit line 
if you want the flag to be called differently than "java" (the default). 
Not sure if any ebuild ever overrided that, it's just the possibility.

> And shouldn't the package append the USE fag (IUSE="${IUSE}
> ${JAVA_PKG_OPT_USE}") instead of replacing it?

No, portage itself takes care to put eclass-defined and ebuild-defined 
IUSE together.

> And in order to solve the conflict that may introduce when several
> eclasses overwrite the pre* functions, shouldn't you EXPORT_FUNCTIONS
> them?

No, EXPORT_FUNCTIONS is for exporting the phases itself, not phase 
hooks. Both seem to solve conflict in a way that the later 
defined/inherited wins, so in the end you get one phase function and one 
phase hook.

-- 
Vlastimil Babka (Caster)
Gentoo/Java
-- 
gentoo-java@g.o mailing list