| 1 |
On 30-11-2007 10:55:57 +0100, Johan Hattne wrote: |
| 2 |
> Now I'm having issues with doxygen. |
| 3 |
|
| 4 |
I don't understand why the darwin9 patch is necessary at all. As I |
| 5 |
don't have such machine myself (at the moment) I can't test. However, |
| 6 |
it looks very wrong, so I will disable the patch for now. |
| 7 |
|
| 8 |
libiconv is libiconv, so it shouldn't differ in signature, right? |
| 9 |
|
| 10 |
|
| 11 |
> It doesn't compile anymore due to doxygen-1.5.3-darwin9 patch, which is |
| 12 |
> dealing with constness of an argument passed to iconv. Because on my |
| 13 |
> darwin8 __APPLE__ is defined, the result of the patched code is to cast |
| 14 |
> const char ** to char **. This seems unnecessary because both system |
| 15 |
> libiconv and portage libiconv accept const char ** as second argument to |
| 16 |
> iconv(). The patch has darwin9 in its name, with which I have no |
| 17 |
> experience, so I can't say what good the patch does there. Where have I |
| 18 |
> gone blind? |
| 19 |
> |
| 20 |
> Also I notice that the cast causes problems on Solaris as well. Wouldn't |
| 21 |
> it be a cleaner solution to have the configure script check whether iconv() |
| 22 |
> accepts a const second argument, and then cast based on the result of the |
| 23 |
> probe? A quick patch doing just that is attached. |
| 24 |
> |
| 25 |
> // Cheers; Johan |
| 26 |
|
| 27 |
|
| 28 |
|
| 29 |
-- |
| 30 |
Fabian Groffen |
| 31 |
Gentoo on a different level |
| 32 |
-- |
| 33 |
gentoo-alt@g.o mailing list |
Archives