Gentoo Archives: gentoo-dev

From: Thomas Sachau <tommy@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] EAPI 3's default src_install needs bikeshedding
Date: Mon, 30 Mar 2009 16:34:01
Message-Id: 49D0F46C.4000900@gentoo.org
In Reply to: [gentoo-dev] EAPI 3's default src_install needs bikeshedding by Ciaran McCreesh
1 Ciaran McCreesh schrieb:
2 > So far, we've got this, by agreement of the Council:
3 >
4 > * There will be a default src_install in EAPI 3
5 > * It will have a DOCS variable, or something along those lines.
6 >
7 > I'd like to suggest the following too:
8 >
9 > * If DOCS is explicitly specified, it is an error if anything in it
10 > doesn't exist.
11 > * If DOCS isn't explicitly specified, it isn't an error if anything in
12 > its default, if it has one, doesn't exist.
13 >
14 > We don't have an implementation yet. So I'll start off with this:
15 >
16 > default_src_install() {
17 > emake -j1 DESTDIR="${D}" install
18
19 Why do you want to force -j1 here?
20
21 And i had this proposal some months ago, which noone argued against any more (the default list may
22 of course be extended):
23
24 from http://archives.gentoo.org/gentoo-dev/msg_be89b62ad12881ce3dfe1d417ae80005.xml :
25
26 So what about this funcion for the next EAPI and also implementation in base.eclass?
27
28 default_src_install() {
29 if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then
30 emake DESTDIR="${D}" install || die "emake install failed"
31 fi
32 if [ -n "${DOCS}" ]; then
33 dodoc ${DOCS} || die "dodoc failed"
34 else
35 for x in AUTHORS ChangeLog NEWS README; do
36 if [ -e ${x} ]; then
37 dodoc ${x} || die "dodoc ${x} failed"
38 fi
39 done
40 fi
41 }
42
43
44 --
45 Thomas Sachau
46
47 Gentoo Linux Developer

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] EAPI 3's default src_install needs bikeshedding Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>
Re: [gentoo-dev] EAPI 3's default src_install needs bikeshedding Robert Buchholz <rbu@g.o>