| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
On 07/17/2013 11:42 PM, Rick "Zero_Chaos" Farina wrote: |
| 5 |
> On 07/17/2013 05:34 PM, hasufell wrote: |
| 6 |
>> On 07/17/2013 11:28 PM, Rick "Zero_Chaos" Farina wrote: |
| 7 |
>>> On 07/17/2013 05:17 PM, Chris Reffett wrote: |
| 8 |
>>>> On 07/17/2013 04:57 PM, hasufell wrote: |
| 9 |
>>>>> I know there was an announcement about the upcoming change |
| 10 |
>>>>> to cmake-utils.eclass, however... it is not enough to give |
| 11 |
>>>>> a deadline without caring if people actually fixed it by |
| 12 |
>>>>> then. |
| 13 |
> |
| 14 |
>>>>> By doing that you risk breaking stable packages which is |
| 15 |
>>>>> not trivial. |
| 16 |
> |
| 17 |
>>>>> You _must_ do a tinderbox run, test that stuff in an |
| 18 |
>>>>> overlay or whatever. You are responsible for ALL reverse |
| 19 |
>>>>> deps. |
| 20 |
> |
| 21 |
>>>>> The way it was done... was not appropriate. Please be more |
| 22 |
>>>>> careful next time. There are still incoming bugs about |
| 23 |
>>>>> broken base_src_* calls. (see the tracker) |
| 24 |
> |
| 25 |
> |
| 26 |
>>>> I discussed this with hasufell on IRC, but I'll lay out the |
| 27 |
>>>> response on the list too. Yes, this was my fault. We (KDE |
| 28 |
>>>> team) tested in our overlay, but none of the packages there |
| 29 |
>>>> use the base_src_* calls, which is why it didn't come up in |
| 30 |
>>>> testing, and I did not realize that there were packages that |
| 31 |
>>>> did rely on the implicit base inherit to call base_src_* |
| 32 |
>>>> directly. |
| 33 |
> |
| 34 |
>>> ...and that is why it isn't permitted to directly use an |
| 35 |
>>> eclass that you don't inherit. While I agree testing could |
| 36 |
>>> (should) have been better, the fact that people ignore the |
| 37 |
>>> rules for writing ebuilds shouldn't entirely fall on the KDE |
| 38 |
>>> team. |
| 39 |
> |
| 40 |
> |
| 41 |
> Considering this is a QA violation, perhaps it is possible to add a |
| 42 |
> check in repoman for using something from an eclass which you |
| 43 |
> didn't inherit. I doubt the slowdown would be horrible and clearly |
| 44 |
> it would catch a huge number of QA violations. |
| 45 |
> |
| 46 |
|
| 47 |
That will yield false positives. Some eclases are explicitly designed |
| 48 |
in a way that you do NOT need to directly inherit it's helpers such as |
| 49 |
python-r1 and python-utils-r1. |
| 50 |
-----BEGIN PGP SIGNATURE----- |
| 51 |
Version: GnuPG v2.0.20 (GNU/Linux) |
| 52 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 53 |
|
| 54 |
iQEcBAEBAgAGBQJR5xECAAoJEFpvPKfnPDWzzRQH/RbkJCvLvpvdLHnb6grJWf3K |
| 55 |
hiKYl2ee5ziqPgx2rLY6HY6L2QN2XuKJ2nmUluvi8s7OIqnKvcH7l3HSJzK5d+2C |
| 56 |
48FNmacLvOJPVpN3cw5h1uH3Jcff0lFXtcYaPBDNlMoYdbY+b3ad+AbXpTHR9rBX |
| 57 |
UkM7W8ung1cH30oed8HZreK4a+6G+8MsqJbZlHJhnAstyWWklIUrpgvKo2kiorfl |
| 58 |
fPvtWhz05hxRUji/Nv3rf4gln9o2MPj0/pa9KZNTKqvBZtX/3SRWVCWvMH6xqXDw |
| 59 |
zQa4pYwkYdbiFS3WW6p08D9I3vMQ/gJ0ZY51OVTVLAVYBrWqd5WA4r4CT7x9QTI= |
| 60 |
=2B+w |
| 61 |
-----END PGP SIGNATURE----- |
Archives