1 |
-----BEGIN PGP SIGNED MESSAGE----- |
2 |
Hash: SHA1 |
3 |
|
4 |
On 07/17/2013 05:47 PM, hasufell wrote: |
5 |
> On 07/17/2013 11:42 PM, Rick "Zero_Chaos" Farina wrote: |
6 |
>> On 07/17/2013 05:34 PM, hasufell wrote: |
7 |
>>> On 07/17/2013 11:28 PM, Rick "Zero_Chaos" Farina wrote: |
8 |
>>>> On 07/17/2013 05:17 PM, Chris Reffett wrote: |
9 |
>>>>> On 07/17/2013 04:57 PM, hasufell wrote: |
10 |
>>>>>> I know there was an announcement about the upcoming change |
11 |
>>>>>> to cmake-utils.eclass, however... it is not enough to give |
12 |
>>>>>> a deadline without caring if people actually fixed it by |
13 |
>>>>>> then. |
14 |
> |
15 |
>>>>>> By doing that you risk breaking stable packages which is |
16 |
>>>>>> not trivial. |
17 |
> |
18 |
>>>>>> You _must_ do a tinderbox run, test that stuff in an |
19 |
>>>>>> overlay or whatever. You are responsible for ALL reverse |
20 |
>>>>>> deps. |
21 |
> |
22 |
>>>>>> The way it was done... was not appropriate. Please be more |
23 |
>>>>>> careful next time. There are still incoming bugs about |
24 |
>>>>>> broken base_src_* calls. (see the tracker) |
25 |
> |
26 |
> |
27 |
>>>>> I discussed this with hasufell on IRC, but I'll lay out the |
28 |
>>>>> response on the list too. Yes, this was my fault. We (KDE |
29 |
>>>>> team) tested in our overlay, but none of the packages there |
30 |
>>>>> use the base_src_* calls, which is why it didn't come up in |
31 |
>>>>> testing, and I did not realize that there were packages that |
32 |
>>>>> did rely on the implicit base inherit to call base_src_* |
33 |
>>>>> directly. |
34 |
> |
35 |
>>>> ...and that is why it isn't permitted to directly use an |
36 |
>>>> eclass that you don't inherit. While I agree testing could |
37 |
>>>> (should) have been better, the fact that people ignore the |
38 |
>>>> rules for writing ebuilds shouldn't entirely fall on the KDE |
39 |
>>>> team. |
40 |
> |
41 |
> |
42 |
>> Considering this is a QA violation, perhaps it is possible to add a |
43 |
>> check in repoman for using something from an eclass which you |
44 |
>> didn't inherit. I doubt the slowdown would be horrible and clearly |
45 |
>> it would catch a huge number of QA violations. |
46 |
> |
47 |
> |
48 |
> That will yield false positives. Some eclases are explicitly designed |
49 |
> in a way that you do NOT need to directly inherit it's helpers such as |
50 |
> python-r1 and python-utils-r1. |
51 |
> |
52 |
> |
53 |
It is my understanding that if you directly use a function from an |
54 |
eclass you are REQUIRED to inherit that eclass. Given that kind of |
55 |
sanity would have prevented these failures I find it difficult to |
56 |
believe my understanding is wrong, but I am willing to learn. |
57 |
|
58 |
I think I'll start inheriting base.eclass so I can use multilib |
59 |
functions. I mean, base.eclass inherits eutils.eclass which inherits |
60 |
multilib.eclass so it should work out fine, right? |
61 |
|
62 |
- -Zero |
63 |
-----BEGIN PGP SIGNATURE----- |
64 |
Version: GnuPG v2.0.19 (GNU/Linux) |
65 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
66 |
|
67 |
iQIcBAEBAgAGBQJR5xLGAAoJEKXdFCfdEflKe/sP/jo7mFijN9jzpbK4/4IAigR/ |
68 |
CuF+gyMh6r8fxDRCKBZ02T04hMhM6XDbafNKGaDstXbLLI6o6xAgGLboeZxo6tj+ |
69 |
GFD+u4gqjN4EWRGeuHS+bzJErEBEt1XpMecaPHyNs6CZF+/XTL6zOZOsKWYAELzO |
70 |
1mlTLp5dn4XCbtC8llsgey1sxq42kuN93JWRqODVPlU5lwZD7cbTpgVV6nQrz36n |
71 |
NeS0FfjIs/UN8/Rix0xaC4frEG86Zv+ES1R/HB6UqDhx+P1hdRpBGVTNF6eLOMvV |
72 |
JJA735pWeN6xgcdrcOrCIGVQTfptaD+tlYfSjL1aeN/Bw1LemyChwsCHd5PE8sgv |
73 |
z63zTiMvR4Mm12KG8xYtm2ygTSdrjCvZz5/ZaX6wnJuCAALGs6Z2dTa27YQBBtlD |
74 |
z4UXXG1fWImcYL1J26rMzapzSzQeXPYThedpCSRIiIs876RQhuE/M7/ZACNveTAR |
75 |
I5QwxY9ZOtol9+ucvRn+8BqS24pRw0DwlWEUTYOWxHcgcMHFw3EzH0Zy0AUYj7yc |
76 |
JrawQlWrhtSYSzScEpEvwlbU+zvZbWi/BXo+K8gUGq+hqseq2vLcfAyTzUA/lyYS |
77 |
oBeAlJVBxFBKsO/64byItWY0la5E4w8T6qy+sgFvlnoFG3rO+/jWSfiEhDOSffCS |
78 |
BLycpk3pzcBSOmTBnJrf |
79 |
=Xgsq |
80 |
-----END PGP SIGNATURE----- |