Gentoo Archives: gentoo-dev

From: Pacho Ramos <pacho@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] skel.ebuild: Update comments for inherit, SLOT, KEYWORDS.
Date: Sun, 31 Dec 2017 19:07:46
Message-Id: 1514747253.2223.2.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] skel.ebuild: Update comments for inherit, SLOT, KEYWORDS. by William Hubbs
1 El dom, 31-12-2017 a las 12:12 -0600, William Hubbs escribió:
2 > On Sun, Dec 31, 2017 at 06:44:39PM +0100, Michał Górny wrote:
3 > > W dniu nie, 31.12.2017 o godzinie 14∶31 +0100, użytkownik Ulrich Müller
4 > > napisał:
5 > > > epatch() is provided by epatch.eclass now. Also comment the inherit
6 > > > line, since not every ebuild will use it.
7 > > >
8 > > > Empty SLOT doesn't disable slots, but is outright illegal in all EAPIs.
9 > > > Similar for KEYWORDS="*", which isn't "deprecated" but invalid.
10 > > > ---
11 > > > skel.ebuild | 9 ++++-----
12 > > > 1 file changed, 4 insertions(+), 5 deletions(-)
13 > > >
14 > > > diff --git a/skel.ebuild b/skel.ebuild
15 > > > index 7ac9dfb7d6d8..4c19b1de4cb8 100644
16 > > > --- a/skel.ebuild
17 > > > +++ b/skel.ebuild
18 > > > @@ -13,9 +13,9 @@
19 > > > EAPI=6
20 > > >
21 > > > # inherit lists eclasses to inherit functions from. For example, an
22 > > > ebuild
23 > > > -# that needs the epatch function from eutils.eclass won't work without
24 > > > the
25 > > > +# that needs the epatch function from epatch.eclass won't work without
26 > > > the
27 > > > # following line:
28 > > > -inherit eutils
29 > > > +#inherit epatch
30 > >
31 > > Well, given that it's EAPI 6 and we do not want to encourage people to
32 > > use epatch there, I would prefer if we replaced that example with
33 > > something else. But it's just a wishful thinking here.
34 >
35 > +1, but I'm not going to suggest what to replace it with.
36 >
37 > William
38
39 Why not eapply (and drop inherit then)? :/

Replies