| 1 |
On Thu, 2021-09-02 at 14:58 +0200, Michał Górny wrote: |
| 2 |
> > |
| 3 |
> Apparently, need_apache* is the problem. Most of the ebuilds in www- |
| 4 |
> apache/* are calling it: |
| 5 |
> |
| 6 |
|
| 7 |
The apache-module eclass tells you to do that because it needs some of |
| 8 |
those APACHE_* paths. It should really be figuring them out itself |
| 9 |
rather than telling the user to call a function that does it in global |
| 10 |
scope. It's an easy fix: |
| 11 |
|
| 12 |
APXS=apxs |
| 13 |
APACHE_MODULESDIR=$(apxs -q libexecdir) |
| 14 |
APACHE_MODULES_CONFDIR=$(apxs -q sysconfdir)/modules.d |
| 15 |
APACHE_VHOSTS_CONFDIR=$(apxs -q sysconfdir)/vhosts.d |
| 16 |
|
| 17 |
On the one hand, we probably don't want ebuild maintainers trying to |
| 18 |
solve that themselves when the eclass could do it. But for whatever |
| 19 |
such a promise is worth, it also feels wrong to promise that apache- |
| 20 |
module will provide all of depend.apache -- what if we someday apply |
| 21 |
the fix above to apache-module and want to drop the depend.apache |
| 22 |
inherit? |
| 23 |
|
| 24 |
If we do ever update apache-module, updating ebuilds and retiring |
| 25 |
depend.apache would be a lot easier if you could find the candidates |
| 26 |
with `git grep depend.apache`, rather than having to look through all |
| 27 |
consumers of apache-module for implicit uses of depend.apache. |
Archives