1 |
-----BEGIN PGP SIGNED MESSAGE----- |
2 |
Hash: SHA256 |
3 |
|
4 |
On 11/08/15 04:57 AM, Tobias Klausmann wrote: |
5 |
> The more we stuff into the summary line, the harder it will be to |
6 |
> write meaningful summaries. And thus, people will write crappy ones |
7 |
> or ignore the length limit. I recommend against any more |
8 |
> prescription over "Add the the cat/pn if meaningful, don't use more |
9 |
> than 75 characters". |
10 |
> |
11 |
> The cat/pn rule is tricky anyway: what if one commit touches 100 |
12 |
> packages? Or should that be split into 100 commits for easier |
13 |
> partial rollback? |
14 |
> |
15 |
> Regards, Tobias |
16 |
> |
17 |
|
18 |
|
19 |
The summary line limit is going to be a real issue, tbh. I think it |
20 |
would probably be best to adopt the convention of putting a few |
21 |
choice, perhaps even canned, phrases in the summary line, and ensure |
22 |
any and all details (effectively what the summary line used to be for |
23 |
when it had practically no limit) within the commit message body instead |
24 |
. |
25 |
|
26 |
Stuff like 'cat/pn: version bumps', 'cat/pn: new features', 'cat/pn: |
27 |
adjusted dependencies' are generic (and short) enough yet descriptive |
28 |
enough to see what went on while scanning the log. 'Fix bug' IMO in |
29 |
the summary doesn't work at all because, although its accurate, that |
30 |
bug could literally be anything at all. |
31 |
|
32 |
Multi-package commits are going to be more of an issue of course.. I |
33 |
did one last night, fortunately I think I can get away with using |
34 |
"mozilla packages" in place of cat/pn since it is a very specific set |
35 |
of packages. Perhaps for sweeping changes like that we can use the |
36 |
herdname or projectname or the category name (if its a particular |
37 |
category only)? |
38 |
|
39 |
|
40 |
-----BEGIN PGP SIGNATURE----- |
41 |
Version: GnuPG v2 |
42 |
|
43 |
iF4EAREIAAYFAlXKBpIACgkQAJxUfCtlWe3pQgD8Ct1elGvDIObKKvskQJ1jCZIK |
44 |
cYvuWdMD7pobr/hH6iIA/jnYirAb9CDe4iNlVPqG2AKYbj9NJdGnpoL/TFhJtj8U |
45 |
=vnTb |
46 |
-----END PGP SIGNATURE----- |