1 |
On Sat, 16 Apr 2016 19:01:02 +0000 (UTC) |
2 |
"Anthony G. Basile" <blueness@g.o> wrote: |
3 |
|
4 |
> commit: ad0c2ab2bdbd34f4550e49c56cfd5974d6a2c07a |
5 |
> Author: Anthony G. Basile <blueness <AT> gentoo <DOT> org> |
6 |
> AuthorDate: Sat Apr 16 19:08:23 2016 +0000 |
7 |
> Commit: Anthony G. Basile <blueness <AT> gentoo <DOT> org> |
8 |
> CommitDate: Sat Apr 16 19:08:23 2016 +0000 |
9 |
> URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ad0c2ab2 |
10 |
> |
11 |
> ssl-cert.eclass: add libressl support |
12 |
> |
13 |
> eclass/ssl-cert.eclass | 12 ++++++++---- |
14 |
> 1 file changed, 8 insertions(+), 4 deletions(-) |
15 |
> |
16 |
> diff --git a/eclass/ssl-cert.eclass b/eclass/ssl-cert.eclass |
17 |
> index 002de76..2538f4d 100644 |
18 |
> --- a/eclass/ssl-cert.eclass |
19 |
> +++ b/eclass/ssl-cert.eclass |
20 |
> @@ -30,10 +30,10 @@ |
21 |
> |
22 |
> if [[ "${SSL_DEPS_SKIP}" == "0" ]]; then |
23 |
> if [[ "${SSL_CERT_MANDATORY}" == "0" ]]; then |
24 |
> - DEPEND="${SSL_CERT_USE}? ( dev-libs/openssl:0= )" |
25 |
> + DEPEND="${SSL_CERT_USE}? ( || ( dev-libs/openssl:0= dev-libs/libressl:0= ) )" |
26 |
> IUSE="${SSL_CERT_USE}" |
27 |
> else |
28 |
> - DEPEND="dev-libs/openssl:0=" |
29 |
> + DEPEND="|| ( dev-libs/openssl:0= dev-libs/libressl:0= )" |
30 |
> fi |
31 |
> fi |
32 |
> |
33 |
|
34 |
Congratulations! You've just committed an invalid dependency that is |
35 |
going to cause true mayhem on every package using the eclass. |
36 |
|
37 |
But why would anyone send patches for review, or even start wondering |
38 |
that we might be using USE=libressl all around for some reason... |
39 |
|
40 |
-- |
41 |
Best regards, |
42 |
Michał Górny |
43 |
<http://dev.gentoo.org/~mgorny/> |