| 1 |
On Saturday 15 September 2007, Donnie Berkholz wrote: |
| 2 |
> On 07:19 Sat 15 Sep , Hans de Graaff (graaff) wrote: |
| 3 |
> > SITEPACKAGE=/usr/lib/xemacs/site-packages |
| 4 |
> |
| 5 |
> Is using get_libdir() a concern here? |
| 6 |
|
| 7 |
looks it to me |
| 8 |
|
| 9 |
> > xemacs-elisp-compile () { |
| 10 |
> > ${XEMACS_BATCH_CLEAN} -f batch-byte-compile "$@" |
| 11 |
> > xemacs-elisp-make-autoload-file "$@" |
| 12 |
> > } |
| 13 |
> > |
| 14 |
> > xemacs-elisp-install () { |
| 15 |
> > local subdir="$1" |
| 16 |
> > shift |
| 17 |
> > ( # use sub-shell to avoid possible environment polution |
| 18 |
> > dodir "${SITEPACKAGE}"/lisp/"${subdir}" |
| 19 |
> > insinto "${SITEPACKAGE}"/lisp/"${subdir}" |
| 20 |
> > doins "$@" |
| 21 |
> > ) || die "Installing lisp files failed" |
| 22 |
> > } |
| 23 |
> |
| 24 |
> The lack of parallels between these two functions bothers me. One dies |
| 25 |
> and the other doesn't, which makes later code using them look wrong. It |
| 26 |
> would be neater to die in both of these functions. |
| 27 |
> |
| 28 |
> Also, try using { } around a block of code instead of ( ), which creates |
| 29 |
> a subshell. |
| 30 |
|
| 31 |
erm, what ? () is a subshell, {} is a list of grouped commands ... |
| 32 |
-mike |
Archives