1 |
W dniu pią, 16.02.2018 o godzinie 02∶17 +0200, użytkownik Mart Raudsepp |
2 |
napisał: |
3 |
> Hello, |
4 |
> |
5 |
> Before writing the obvious patches, would anyone terribly object to |
6 |
> moving gnome2_icon_cache_update into xdg-utils.eclass instead and |
7 |
> hooking it up via savelist guard in xdg.eclass (only running in |
8 |
> postinst/postrm when really needed)? |
9 |
> |
10 |
> The gtk icon cache format isn't used by gtk+ only - it's used by Qt as |
11 |
> well these days; and either way if anything installs things per the |
12 |
> icon specs, the caches should be updated for gtk/qt to see it (even if |
13 |
> the program itself is written in motif or something). |
14 |
|
15 |
Maybe it'd be reasonable to rename it while at it, to gtk_icon_cache* |
16 |
or xdg_gtk_icon_cache*. It would really suck to have xdg* provide |
17 |
a function named gnome2*, especially when it's not specific to GNOME. |
18 |
|
19 |
> |
20 |
> Open dilemmas: |
21 |
> |
22 |
> * To DEPEND on gtk-update-icon-cache, or to rely on the toolkits to |
23 |
> pull it in and only run the updates if the helper is present. We have |
24 |
> it split out from gtk+ codebase, so it only has glib/gdk-pixbuf deps |
25 |
> right now. |
26 |
> |
27 |
> * If it's worth trying to avoid double calls in postint and postrm for |
28 |
> ebuilds that inherit xdg and call gnome2_icon_cache_update manually |
29 |
> right now on top (due to xdg.eclass not doing it for them). |
30 |
> |
31 |
> |
32 |
> If these changes are agreeable, then they could also be batched into a |
33 |
> single push with the documentation update patches pending from mgorny |
34 |
> for a single metadata cache invalidation of gnome2-utils.eclass using |
35 |
> ebuilds. |
36 |
> |
37 |
> If this looks good, I can write patches soon, though there's always |
38 |
> other things to do too (like work on integrating a gnome-meson.eclass |
39 |
> or meson-desktop.eclass on top of this), so help with patches welcome |
40 |
> as well. |
41 |
> |
42 |
> |
43 |
> Mart |
44 |
> |
45 |
|
46 |
-- |
47 |
Best regards, |
48 |
Michał Górny |