| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA512 |
| 3 |
|
| 4 |
On October 23, 2016 11:29:49 PM PDT, "Michał Górny" <mgorny@g.o> wrote: |
| 5 |
>Dnia 24 października 2016 07:32:26 CEST, Daniel Campbell |
| 6 |
><zlg@g.o> napisał(a): |
| 7 |
>>On 10/19/2016 02:10 AM, Ulrich Mueller wrote: |
| 8 |
>>>>>>>> On Wed, 19 Oct 2016, Kent Fredric wrote: |
| 9 |
>>> |
| 10 |
>>>> On Tue, 18 Oct 2016 21:45:05 -0500 |
| 11 |
>>>> Matthew Thode <prometheanfire@g.o> wrote: |
| 12 |
>>> |
| 13 |
>>>>> Does pram allow you to pass options to git |
| 14 |
>>>>> am (signedoffby for instance)? |
| 15 |
>>> |
| 16 |
>>>> It doesn't presently allow arbitrary arguments, and it would |
| 17 |
>>>> probably be wise to avoid need for such arguments and prefer |
| 18 |
>>>> convention over configuration, given what this is. |
| 19 |
>>> |
| 20 |
>>>> --signoff is already a default: |
| 21 |
>>> |
| 22 |
>>>> |
| 23 |
>>https://metacpan.org/source/MONSIEURP/Gentoo-App-Pram-0.003000/lib/Gentoo/App/Pram.pm#L71 |
| 24 |
>>> |
| 25 |
>>> Maybe I have missed something, but why would one use --signoff for |
| 26 |
>>> a Gentoo commit? |
| 27 |
>>> |
| 28 |
>>> For Linux (the kernel), the meaning of the line is that the |
| 29 |
>>> contributor certifies the DCO (Developer's Certificate of Origin) |
| 30 |
>>[1]. |
| 31 |
>>> As we don't have a Gentoo DCO, it is not at all clear to me what the |
| 32 |
>>> meaning of a Signed-off-by: line would be in the context of the |
| 33 |
>>gentoo |
| 34 |
>>> tree. |
| 35 |
>>> |
| 36 |
>>> Even worse, I see commits having Signed-off-by: lines with obvious |
| 37 |
>>> pseudonyms instead of a real name, which would be meaningless even |
| 38 |
>if |
| 39 |
>>> one would say that the Linux rules apply. (Also, we have the rule |
| 40 |
>>that |
| 41 |
>>> real names must be provided for all developers, with no exceptions |
| 42 |
>to |
| 43 |
>>> be made for people doing copyrightable work [2].) |
| 44 |
>>> |
| 45 |
>>> Ulrich |
| 46 |
>>> |
| 47 |
>>> [1] |
| 48 |
>>http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=dca22a63fd036c3ebb50212060eba0080f178126#n428 |
| 49 |
>>> [2] |
| 50 |
>>https://wiki.gentoo.org/wiki/Project:Recruiters#What_does_the_recruitment_process_involve.3F |
| 51 |
>>> |
| 52 |
>>The way I understood "signed off by" for Gentoo is "I am a developer |
| 53 |
>>who |
| 54 |
>>looked at the code and tested it, confirming it works on my system". |
| 55 |
>If |
| 56 |
>>an AT signs off, they are certifying that it passes their test muster. |
| 57 |
>> |
| 58 |
>>It's a more formal "looks good to me", and provides a point of |
| 59 |
>>accountability if the commit _isn't_ up to par. |
| 60 |
> |
| 61 |
>How about Gentoo developers stopping to reuse things that have |
| 62 |
>well-defined meaning for something completely different? |
| 63 |
|
| 64 |
I did say "to my understanding". I wasn't aware of DCOs. Regardless, practices and workflows differ between projects, and it doesn't surprise me to see projects that use the same words differently. Not that we should, of course. What would you call what I decribed, though; Acked? |
| 65 |
- -- |
| 66 |
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
| 67 |
-----BEGIN PGP SIGNATURE----- |
| 68 |
|
| 69 |
iQJRBAEBCgA7NBxEYW5pZWwgQ2FtcGJlbGwgKEdlbnRvbyBEZXZlbG9wZXIpIDx6 |
| 70 |
bGdAZ2VudG9vLm9yZz4FAlgNtlQACgkQASQOlFA54XDmhw/9HbEDo60eZp38AUMf |
| 71 |
TgCnj8fYka65Pc9CjLBpJAcvekM2oRcSHB61FdAy8tqIVb7Zx8IvIXNXseOc9sP4 |
| 72 |
0qNSy89gOKkNRIPx/DC8JFVlmK6YoD5ezZ05tKdzFwcdBvHcJWhKfbO2R2f6L/g5 |
| 73 |
woLZb4qgxQdFNwOykDy2Ux83W075hFbHaAw9zwpVKAb9LvtMfiJJ2AYEecmnOZDx |
| 74 |
uVVnkxMrOpAKABhcUqc3d8MnB2NCPwZogL3Z+71duy3puU+71Y338w64vrXDioBY |
| 75 |
4pPVIrXk4Ifa799xjCj+Wr2sWYzgHqdJe/cReYZXjRMRzxbvLiZo1PWLejMWgczk |
| 76 |
CRX0lh6o0cohDxX8oEMiY3s3COqQvD928FzppGkW+8+XQaqXE64VEyHszMuILPL3 |
| 77 |
cLBbRt39ujmSPJUp/5mX3yUA761QcvRv4wPaDAf81NYllepLoYh2IL9j+5Iqfrf4 |
| 78 |
QNm/bUeuwxnvLZOMNGTyih/5w2GvhKhLunp170Lm4LGf6BQoEw60ZYot6OlvKFLF |
| 79 |
Th8oaacTc9acVa7K2lDlH+2ARsqFvfwQgEjGaLczfhFXi8lzIckgtb7Shn1UjEB5 |
| 80 |
u/7AwgGmO0rC3Mt9GXL7P5xYgWInNxEeyNP+O0d7Lu5CnBsKI9fUvoYnGZblSAWn |
| 81 |
yt44aBJYOgIzLklGfuQm6xhgdDc= |
| 82 |
=eesR |
| 83 |
-----END PGP SIGNATURE----- |
Archives