| 1 |
On Thu, 5 Sep 2019 09:04:23 -0500 |
| 2 |
Gordon Pettey <petteyg359@×××××.com> wrote: |
| 3 |
|
| 4 |
> You'll note the bit you quoted in defense of skipping review says |
| 5 |
> "changes", and the bit about new eclasses says "do not skip this step". |
| 6 |
|
| 7 |
Emphasis added: |
| 8 |
|
| 9 |
----- |
| 10 |
BEFORE committing a NEW eclass to the tree, it SHOULD be emailed to the |
| 11 |
gentoo-dev mailing list with a justification and a proposed |
| 12 |
implementation. DO NOT SKIP this step — sometimes a better |
| 13 |
implementation or an alternative which does not require a new eclass |
| 14 |
will be suggested. |
| 15 |
----- |
| 16 |
|
| 17 |
|
| 18 |
If its mandatory, it must say "MUST" not "SHOULD", SHOULD is a |
| 19 |
suggestion, following a suggestion with an imperative just adds |
| 20 |
predictable confusion. |
| 21 |
|
| 22 |
Either fix the "should", or drop the "DO NOT SKIP". |
| 23 |
|
| 24 |
Otherwise you're just giving mixed messages. |
Archives