Re: [gentoo-dev] Please review fortran-2.eclass next round

[Mike Frysinger]

On Friday, June 17, 2011 02:05:59 justin wrote:
> On 17/06/11 05:03, Mike Frysinger wrote:
> >> # @ECLASS: fortran-2.eclass
> >
> > i dont see fortran.eclass.  what's with the "-2" ?
>
> There was a fortran eclass, which did completely different things. In
> order  to not break an ancient package (outside the tree) I decided to
> go to the new name, which also underlines the new functionality.

thanks; makes sense

> >> # internal function
> >
> > use the @INTERNAL tag and proper eclass documentation
>
> I wasn't aware of that. We are lacking any documentation about the
> proper documentation for manpages in all eclass writing guides.

the syntax is fully documented in the utility that generates it.  see the awk 
in the eclass-manpages filesdir.

> >> 		(( ${ret} )) || break
> >
> > a little odd syntax, but i guess it works ...
>
> I don't know any other way how I can jump out of the loop. The complete
> things simulates the autoconf behavior.

i just meant using "(( ${ret} ))" rather than "[[ ${ret} -eq 0 ]]"

> >> 		ewarn "The support for EAPI=${EAPI} by the fortran-2.eclass"
> >
> > why ?  it's causing you no real trouble to do so
>
> The suggestion was to only support EAPI=4. I don't like this completely
> as all fortran packages should directly use the eclass in order to make
> it smooth for users. The delay should give some time to come up with
> stable versions for all fortran packages at EAPI=4, but allow the use in
> every ebuild right away.

if you want to keep older EAPI support, and/or it's trivial to do so, then 
you're free to disagree with the suggestion and keep support.  you are the 
maintainer of this after all.
-mike