Gentoo Archives: gentoo-dev

From: "W. Trevor King" <wking@×××××××.us>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFI: A better workflow for github pull requests
Date: Sat, 12 Sep 2015 21:09:46
Message-Id: 20150912210734.GA14809@odin.tremily.us
In Reply to: Re: [gentoo-dev] RFI: A better workflow for github pull requests by hasufell
1 On Sat, Sep 12, 2015 at 10:11:27PM +0200, hasufell wrote:
2 > We should probably auto-attach the patch from the pull request. This
3 > can easily be done with link-rewriting, e.g.:
4 > https://github.com/gentoo/gentoo/pull/83 to
5 > https://github.com/gentoo/gentoo/pull/83.patch
6 > yields a nice downloadable patch.
7
8 Why not [1]:
9
10 $ GITHUB_REMOTE=origin # adjust this to match whatever you call GitHub's gentoo/gentoo
11 $ git config --add remote.$GITHUB_REMOTE.fetch +refs/pull/*/head:refs/remotes/$GITHUB_REMOTE/pr/*
12
13 That will let you fetch the remote branch (e.g. origin/pr/83 assuming
14 ‘origin’ is your GitHub remote). That seems easier than copy/pasting
15 around commits and messing with ‘git am’ and other things that will
16 change the committer, which will in turn invalidate any commit
17 signatures (the patch seems to drop those anyway).
18
19 Cheers,
20 Trevor
21
22 [1]: https://gist.github.com/piscisaureus/3342247
23
24 --
25 This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
26 For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies