Re: [gentoo-dev] RFI: A better workflow for github pull requests

[hasufell]

On 09/12/2015 11:07 PM, W. Trevor King wrote:
> On Sat, Sep 12, 2015 at 10:11:27PM +0200, hasufell wrote:
>> We should probably auto-attach the patch from the pull request. This
>> can easily be done with link-rewriting, e.g.:
>> https://github.com/gentoo/gentoo/pull/83 to
>> https://github.com/gentoo/gentoo/pull/83.patch
>> yields a nice downloadable patch.
>
> Why not [1]:
>
>   $ GITHUB_REMOTE=origin  # adjust this to match whatever you call GitHub's gentoo/gentoo
>   $ git config --add remote.$GITHUB_REMOTE.fetch +refs/pull/*/head:refs/remotes/$GITHUB_REMOTE/pr/*
>
> That will let you fetch the remote branch (e.g. origin/pr/83 assuming
> ‘origin’ is your GitHub remote).  That seems easier than copy/pasting
> around commits and messing with ‘git am’ and other things that will
> change the committer, which will in turn invalidate any commit
> signatures (the patch seems to drop those anyway).
>

Because that is not a valid bug report. Patches must be attached to
bugzilla.