1 |
On 3/10/2022 14:59, Alec Warner wrote: |
2 |
> On Thu, Mar 10, 2022 at 10:28 AM Joshua Kinard <kumba@g.o> wrote: |
3 |
>> |
4 |
>> On 3/9/2022 16:47, Matt Turner wrote: |
5 |
>>> On Wed, Mar 9, 2022 at 1:37 PM Matthias Maier <tamiko@g.o> wrote: |
6 |
>>>> |
7 |
>>>> |
8 |
>>>> Just a quick though: |
9 |
>>>> |
10 |
>>>> Looking at the man page of repoman it doesn't look to difficult to |
11 |
>>>> replicate the behavior with pkgcheck. Meaning, we could think of |
12 |
>>>> creating a drop-in replacement for "repoman [full]" (which would just |
13 |
>>>> call pkgcheck) and "repoman commit" which actually does much more than |
14 |
>>>> just prepending the git commit summary line: repoman commit does |
15 |
>>>> |
16 |
>>>> - update the manifest |
17 |
>>>> - bail out if files are not correctly "git add"ed |
18 |
>>>> - add the output of [pkgcheck] as a comment to the git commit |
19 |
>>>> description |
20 |
>>> |
21 |
>>> I wouldn't block anyone from doing this, but it's not something I'm |
22 |
>>> personally interested in pursuing. I see very little value here. |
23 |
>> |
24 |
>> First, you're trying to justify replacing repoman on an entirely subjective |
25 |
>> opinion of "I think <foo> is superior", then when you get feedback on the |
26 |
>> idea, you dismiss that feedback with more opinion. |
27 |
>> |
28 |
>> Why do you not see value here? The actions described are actually quite a |
29 |
>> few useful steps in the process of checking a change into the tree. If you |
30 |
>> expect developers to do those steps on their own, that increases, not |
31 |
>> decreases, the chances of making a mistake. Or are these steps already |
32 |
>> handled by one of the other scripts in the replacement packages you propose? |
33 |
>> If so, please say so and identify which one(s). |
34 |
>> |
35 |
>> My opinion is that any tool that replaces repoman should, at a minimum, |
36 |
>> replace like functionality with like functionality, plus benefits or |
37 |
>> enhancements. This looks more like a step backwards, not a step forwards. |
38 |
> |
39 |
> I'd be interested in hearing your workflow, so we can capture it in |
40 |
> the table (mentioned earlier) so its clear how your existing workflow |
41 |
> will work with the new tools (or perhaps there is a gap, or we need to |
42 |
> craft / add additional tools?) I agree on the face it may not be |
43 |
> obvious what workflows look like. |
44 |
|
45 |
My workflow is really rather standard when working in the tree itself. I |
46 |
work one package directory at a time, apply changes that I've tested outside |
47 |
of the tree in my local repo, eyeball everything a second time to make sure |
48 |
I didn't miss something, regenerate the manifest, git add, run 'repoman full |
49 |
-d -x', fix any issues it finds (if any) and manifest/git add again, then |
50 |
'repoman commit' and supply a commit message with sign-off. Lather, rinse, |
51 |
repeat for other packages. |
52 |
|
53 |
This is more or less how the dev manual and git for developers guide says we |
54 |
should be doing it. Since git is atomic, limit commits to one package at a |
55 |
time, then, when ready, push the changes in a single batch after rebasing |
56 |
(to pickup other dev's changes). |
57 |
|
58 |
If I'm doing something wrong, yell at me in e-mail, open a bug, or call me |
59 |
out on the mailing list and serve me some crow pie. That's how I learn not |
60 |
to repeat it. So far, though, this process has worked well for me for a |
61 |
very long time and I've only had to make minor adjustments at key points, |
62 |
like switching from CVS to git. |
63 |
|
64 |
-- |
65 |
Joshua Kinard |
66 |
Gentoo/MIPS |
67 |
kumba@g.o |
68 |
rsa6144/5C63F4E3F5C6C943 2015-04-27 |
69 |
177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943 |
70 |
|
71 |
"The past tempts us, the present confuses us, the future frightens us. And |
72 |
our lives slip away, moment by moment, lost in that vast, terrible in-between." |
73 |
|
74 |
--Emperor Turhan, Centauri Republic |